Skip to content

gh-63016: Add flags parameter on mmap.flush#139553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 11 commits into from
Dec 27, 2025
Merged

gh-63016: Add flags parameter on mmap.flush #139553

vstinner merged 11 commits into from
Dec 27, 2025

Conversation

@aisk
Copy link
Contributor

@aiskaisk commented Oct 4, 2025•
edited by github-actions bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Oct 4, 2025
Closed
@aisk
Copy link
ContributorAuthor

aisk commented Oct 4, 2025

I noticed a PR #139237 to migrate the mmap module to use AC. We should wait for it to be merged before continue the work.

@aiskaisk marked this pull request as draft October 4, 2025 12:26
@aiskaisk marked this pull request as ready for review October 11, 2025 13:00
@aisk
Copy link
ContributorAuthor

aisk commented Oct 11, 2025

Since #139237 was merged, I rebased the branch and now it's ready for review.

vstinner
vstinner reviewed Dec 23, 2025
View reviewed changes
vstinner
vstinner approved these changes Dec 24, 2025
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please just update the doc (see my comment).

@aisk@vstinner
Update Doc/library/mmap.rst
a471614
Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner
Copy link
Member

vstinner commented Dec 27, 2025

Oh, you have to run make clinic to update Argument Clinic.

@aisk
Copy link
ContributorAuthor

aisk commented Dec 27, 2025

@vstinner Sorry I forgot check the CI status, updated!

@vstinnervstinner enabled auto-merge (squash) December 27, 2025 10:10
@vstinnervstinner merged commit 1af21ea into python:mainDec 27, 2025
46 checks passed
@aiskaisk deleted the mmap-flush-flags branch December 27, 2025 10:45
@picnixz
Copy link
Member

picnixz commented Dec 27, 2025

This broke some build bots: https://buildbot.python.org/#/builders/1232/builds/7610

picnixz added a commit that referenced this pull request Jan 1, 2026
@picnixz
Amend NEWS entries for PRsGH-139553andGH-142790(#143329)
422ca07
@vstinner
Copy link
Member

vstinner commented Jan 7, 2026

This broke some build bots: https://buildbot.python.org/#/builders/1232/builds/7610

It has been fixed by #143230.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aisk@vstinner@picnixz