gh-90949: Fix an "unused function" compiler warning introduced in GH-139234#139558
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The symptom was: > ./Modules/pyexpat.c:202:1: warning: ‘set_invalid_arg’ defined but not used [-Wunused-function] > 202 | set_invalid_arg(pyexpat_state *state, xmlparseobject *self, const char *errmsg) > | ^~~~~~~~~~~~~~~
picnixz changed the title 
Member
picnixz commented Oct 4, 2025
I assume the compiler warning is "unused function" right? |
picnixz approved these changes Oct 4, 2025
ContributorAuthor
hartwork commented Oct 4, 2025
@picnixz yes, I put details into the commit message. |
Member
picnixz commented Oct 4, 2025
Oups, I didn't see it. My bad. Thanks for the fix! |
picnixz changed the title ContributorAuthor
hartwork commented Oct 4, 2025
@picnixz no worries, glad I could help. (The warning showed while working on the backports yesterday where the bundled Expat is not yet at >=2.7.2.) |
picnixz merged commit fc48a3c into python:main 51 checks passed
Uh oh!
There was an error while loading. Please reload this page.
danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
pythonGH-139234 (python#139558) Fix a compiler warning `-Wunused-function` after f04bea4. The `set_invalid_arg` function in `Modules/pyexpat.c` may be unused if the underlying Expat version is less than 2.4.0.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds on top of #139368 to fix a compiler warning that did not exist prior to the work on #90949.
CC @picnixz