Skip to content

gh-84232: Fix pydoc docs.python.org link generation#139995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 7 commits into from
Dec 23, 2025
Merged

gh-84232: Fix pydoc docs.python.org link generation #139995

hugovk merged 7 commits into from
Dec 23, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commented Oct 12, 2025•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Oct 12, 2025
Closed
@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Oct 12, 2025

Requesting Serhiy per experts list.

@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Oct 12, 2025

UBSan failure is unrelated.

@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Oct 13, 2025

@picnixz Thanks for the helpful reviews on the (other) pydoc PR, I also happen to have this one if you are interested, I'd appreciate your thoughts.

serhiy-storchaka
serhiy-storchaka reviewed Oct 13, 2025
View reviewed changes
@StanFromIrelandStanFromIreland changed the title gh-139971: Fix pydoc docs.python.org link generationgh-84232: Fix pydoc docs.python.org link generationOct 13, 2025
@bedevere-appbedevere-appbot mentioned this pull request Oct 13, 2025
Closed
@StanFromIrelandStanFromIreland mentioned this pull request Oct 13, 2025
Closed
merwok
merwok reviewed Dec 15, 2025
View reviewed changes
@merwok
Copy link
Member

merwok commented Dec 15, 2025

I’m ready to review after conflicts are fixed to get this merged!

@merwok
Copy link
Member

merwok commented Dec 15, 2025

I’m not adding the backport labels as the list of modules has differences between versions, and there is a manual step to generate the pydoc data file.

@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Dec 15, 2025•
edited
Loading

a manual step

Yes and no, the script is run during the release process anyway, there is no additional work for RMs:-)

@hugovkhugovk merged commit f9704f1 into python:mainDec 23, 2025
87 of 89 checks passed
@StanFromIrelandStanFromIreland deleted the pydoc-link branch December 23, 2025 09:20
@hugovkhugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 23, 2025
@miss-islington-app
Copy link

miss-islington-appbot commented Dec 23, 2025

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-appbot commented Dec 23, 2025

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 23, 2025
@StanFromIreland@merwok@miss-islington
pythongh-84232: Fixpydocdocs.python.org link generation (pythonGH…
4f9ddba
…-139995) (cherry picked from commit f9704f1) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Éric <merwok@netwok.org>
@miss-islington-app
Copy link

miss-islington-appbot commented Dec 23, 2025

Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f9704f1d84044e46b94f2e4854dae43c1adaa7f1 3.13

@bedevere-app
Copy link

bedevere-appbot commented Dec 23, 2025

GH-143098 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Dec 23, 2025
@bedevere-app
Copy link

bedevere-appbot commented Dec 23, 2025

GH-143099 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Dec 23, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull request Dec 23, 2025
@StanFromIreland@merwok@hugovk
[3.13]pythongh-84232: Fixpydocdocs.python.org link generation (p…
08f473b
…ythonGH-139995) (cherry picked from commit f9704f1) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Éric <merwok@netwok.org>
hugovk pushed a commit that referenced this pull request Dec 23, 2025
@miss-islington@StanFromIreland@merwok
[3.14]gh-84232: Fixpydocdocs.python.org link generation (GH-139995…
a007e95
…) (#143098) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Éric <merwok@netwok.org>
hugovk added a commit that referenced this pull request Dec 23, 2025
@hugovk@StanFromIreland@merwok
[3.13]gh-84232: Fixpydocdocs.python.org link generation (GH-139995…
7dc6acc
…) (#143099) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Éric <merwok@netwok.org>
@hugovkhugovk mentioned this pull request Jan 20, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

@zwarezwareAwaiting requested review from zware

@merwokmerwokAwaiting requested review from merwok

Assignees

@hugovkhugovk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland@merwok@hugovk@serhiy-storchaka