Skip to content

gh-140120: Fix memory leak in HMAC digest#140124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ashm-dev wants to merge 3 commits into from
Closed

gh-140120: Fix memory leak in HMAC digest #140124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11a7bc0
Fix memory leak in HMAC digest
ashm-dev Oct 14, 2025
76f110a
add blurb
ashm-dev Oct 14, 2025
715d76c
Update Modules/_hacl/Hacl_Streaming_HMAC.c
ashm-dev Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Security/2025-10-14-18-58-09.gh-issue-140120.WyeECT.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
Fixes a memory leak in ``Hacl_Streaming_HMAC_digest`` by freeing the
``snd`` and ``thd`` fields of ``tmp_block_state1``.
2 changes: 2 additions & 0 deletions Modules/_hacl/Hacl_Streaming_HMAC.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2378,6 +2378,8 @@ Hacl_Streaming_HMAC_digest(
Hacl_Agile_Hash_state_s *s11 = tmp_block_state1.snd;
update_last(s11, prev_len_last, buf_last, r);
finish0(tmp_block_state1, output);
free_(tmp_block_state1.snd);
free_(tmp_block_state1.thd);
return Hacl_Streaming_Types_Success;
}
KRML_HOST_EPRINTF("KaRaMeL abort at %s:%d\n%s\n",
Expand Down
Loading