Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
GH-140052: Add PyTuple_MakeSingle and PyTuple_MakePair#140132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
sergey-miryanov wants to merge 21 commits into python:main from sergey-miryanov:140052-pytuple-make-pair
Uh oh!
There was an error while loading. Please reload this page.
Closed
Changes from all commits
Commits
Show all changes
21 commits Select commit Hold shift + click to select a range
4e46463 Add PyTuple_Make[Single,Pair]
sergey-miryanov aacb9f2 Add news entry
sergey-miryanov ef7d139 Fix news entry
sergey-miryanov ebb70c9 Revert refcounts.dat changes
sergey-miryanov bb9d532 Revert "Revert refcounts.dat changes"
sergey-miryanov ee4056e Fix refcounts.dat
sergey-miryanov bda2374 Fix news entry
sergey-miryanov 2076783 Apply suggestions from code review
sergey-miryanov d45bd2a Fix docs
sergey-miryanov bd7bc3e Fix tuple_make_single
sergey-miryanov f5bab3c Fix docs
sergey-miryanov 6161535 Move declarations to Include/cpython/tupleobject.h
sergey-miryanov e6d2e0e Update Doc/c-api/tuple.rst
sergey-miryanov 3c0ef7c Remove warning from PyTuple_MakePair docs
sergey-miryanov 270141b Apply suggestions from code review
sergey-miryanov 7c0eaa4 Fix indentation for PyTuple_MakePair docs
sergey-miryanov e27f3a1 Merge branch 'main' into 140052-pytuple-make-pair
sergey-miryanov ce29809 Merge branch '140052-pytuple-make-pair' of github.com:sergey-miryanov…
sergey-miryanov d28311c Merge branch 'main' into 140052-pytuple-make-pair
sergey-miryanov d075bff Check should we track or no tuple created via PyTuple_Make[Single,Pair]
sergey-miryanov 0517223 Update tests accordingly
sergey-miryanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions 2 Misc/NEWS.d/next/Core_and_Builtins/2025-10-15-01-30-28.gh-issue-140052.08spgX.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Add :c:func:`PyTuple_MakeSingle` and :c:func:`PyTuple_MakePair` functions to | ||
| create short-sized tuples. Patch by Sergey Miryanov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, it'll be better not to check this, since we can make another decision in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a small disagreement here.
I think we should explicitly fix the current behavior in the tests.
@efimov-mikhail does not want to fix the behavior that may change in the near future because doing so would require changes to the tests.
We need another opinion on this.