Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commented Oct 15, 2025

@bedevere-appbedevere-appbot added the tests Tests in the Lib/test dir label Oct 15, 2025
@StanFromIrelandStanFromIreland added skip news and removed tests Tests in the Lib/test dir labels Oct 15, 2025
Copy link
Contributor

@itamaroitamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirming the patch fixes the test failure for me

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchakaserhiy-storchaka merged commit 7ac94fc into python:mainOct 16, 2025
61 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2025
Commit (cherry picked from commit 7ac94fc) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

GH-140198 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Oct 16, 2025
vstinner pushed a commit that referenced this pull request Oct 16, 2025
gh-140170: Fix test_site with -s flag (GH-140179) Commit (cherry picked from commit 7ac94fc) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@vstinnervstinner added the needs backport to 3.13 bugs and security fixes label Oct 16, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2025
Commit (cherry picked from commit 7ac94fc) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

GH-140201 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Oct 16, 2025
vstinner pushed a commit that referenced this pull request Oct 16, 2025
gh-140170: Fix test_site with -s flag (GH-140179) Commit (cherry picked from commit 7ac94fc) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.13 (tier-2) has failed when building commit 9fb32eb.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1404/builds/1338) and take a look at the build logs.
  4. Check if the failure is related to this commit (9fb32eb) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1404/builds/1338

Failed tests:

  • test_urllib2net

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 62972), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 62974), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 62974), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 845, in gc_collect gc.collect() ResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 62964), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 62970), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 845, in gc_collect gc.collect() ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 62970), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 62977), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 845, in gc_collect gc.collect() ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 62977), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 62983), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 845, in gc_collect gc.collect() ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 62983), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 62979), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=11, family=2, type=1, proto=6, laddr=('192.168.0.101', 62981), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=11, family=2, type=1, proto=6, laddr=('192.168.0.101', 62981), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 62959), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 62961), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 62961), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 63014), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 63016), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 63016), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/socket_helper.py", line 225, in transient_internet captured_errnos = [getattr(errno, name, num) ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 63012), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 63019), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/socket_helper.py", line 225, in transient_internet captured_errnos = [getattr(errno, name, num) ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 63019), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 63025), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/socket_helper.py", line 225, in transient_internet captured_errnos = [getattr(errno, name, num) ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 63025), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 63028), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 63028), raddr=('68.183.26.59', 21)> Timeout (0:20:00)! Thread 0x00000001f9324800 (most recent call first): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 849 in create_connection File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/ftplib.py", line 354 in ntransfercmd File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 2458 in retrfile File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 1548 in ftp_open File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 466 in _call_chain File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 506 in _open File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 489 in open File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/urllib/request.py", line 189 in urlopen File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 21 in _retry_thrice File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 29 in wrapped File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 373 in test_ftp_timeout File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/case.py", line 606 in _callTestMethod File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/case.py", line 651 in run File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/case.py", line 707 in __call__ File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/suite.py", line 122 in run File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/suite.py", line 84 in __call__ File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/suite.py", line 122 in run File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/suite.py", line 84 in __call__ File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/runner.py", line 240 in run File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/libregrtest/single.py", line 57 in _run_suite File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/libregrtest/single.py", line 37 in run_unittest File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/libregrtest/single.py", line 135 in test_func File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/libregrtest/single.py", line 91 in regrtest_runner File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/libregrtest/single.py", line 138 in _load_run_test File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/libregrtest/single.py", line 181 in _runtest_env_changed_exc File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/libregrtest/single.py", line 281 in _runtest File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/libregrtest/single.py", line 310 in run_single_test File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/libregrtest/worker.py", line 77 in worker_process File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/libregrtest/worker.py", line 112 in main File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/libregrtest/worker.py", line 116 in <module> File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/runpy.py", line 88 in _run_code File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/runpy.py", line 198 in _run_module_as_main Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 63021), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 63023), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 63023), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 62966), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 62968), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 62968), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 63008), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 63010), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in closeself._sock =NoneResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 63010), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" 

@StanFromIrelandStanFromIreland deleted the gh-140170 branch October 16, 2025 12:19
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@StanFromIreland@bedevere-bot@itamaro@serhiy-storchaka@vstinner