Skip to content

GH-139436: Remove references to downloadable PDF documentation#140416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AA-Turner merged 1 commit into from
Oct 21, 2025
Merged

GH-139436: Remove references to downloadable PDF documentation #140416

AA-Turner merged 1 commit into from
Oct 21, 2025

Conversation

@AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commented Oct 21, 2025•
edited by github-actions bot
Loading

@AA-TurnerAA-Turner requested a review from hugovkOctober 21, 2025 12:05
@AA-TurnerAA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 21, 2025
@bedevere-appbedevere-appbot mentioned this pull request Oct 21, 2025
Open
AA-Turner
AA-Turner commented Oct 21, 2025
View reviewed changes
README.rst
code but these are entirely optional.

All trademarks referenced herein are property of their respective holders. No newline at end of file
All trademarks referenced herein are property of their respective holders.
Copy link
MemberAuthor

@AA-TurnerAA-TurnerOct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My editor added a trailing blank line here, seems to have been (accidentally?) removed in 29af6ce (cc @hugovk).

Copy link
Member

@hugovkhugovkOct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the release-tools automation must have removed it. I expect it'll remove it again next time...

Looks like we need an extra newline at https://github.com/python/release-tools/blob/b2179610037b573290a93f4206b81d0788e40477/release.py#L457

Copy link
MemberAuthor

@AA-TurnerAA-TurnerOct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python/release-tools#296

hugovk
hugovk approved these changes Oct 21, 2025
View reviewed changes
README.rst
code but these are entirely optional.

All trademarks referenced herein are property of their respective holders. No newline at end of file
All trademarks referenced herein are property of their respective holders.
Copy link
Member

@hugovkhugovkOct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the release-tools automation must have removed it. I expect it'll remove it again next time...

Looks like we need an extra newline at https://github.com/python/release-tools/blob/b2179610037b573290a93f4206b81d0788e40477/release.py#L457

@AA-TurnerAA-Turner merged commit 4adf08a into python:mainOct 21, 2025
42 checks passed
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsOct 21, 2025
@AA-TurnerAA-Turner deleted the docs/readme-epub branch October 21, 2025 12:37
@miss-islington-app
Copy link

miss-islington-appbot commented Oct 21, 2025

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2025
@AA-Turner@miss-islington
pythonGH-139436: Remove references to downloadable PDF documentation (p…
d201877
…ythonGH-140416) (cherry picked from commit 4adf08a) Co-authored-by: Adam Turner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2025
@AA-Turner@miss-islington
pythonGH-139436: Remove references to downloadable PDF documentation (p…
3ffbd9a
…ythonGH-140416) (cherry picked from commit 4adf08a) Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-appbot commented Oct 21, 2025

GH-140419 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Oct 21, 2025
@bedevere-app
Copy link

bedevere-appbot commented Oct 21, 2025

GH-140420 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Oct 21, 2025
hugovk pushed a commit that referenced this pull request Oct 21, 2025
@miss-islington@AA-Turner
[3.14]GH-139436: Remove references to downloadable PDF documentation (…
d7dc6bf
…GH-140416) (#140419) Co-authored-by: Adam Turner <[email protected]>
hugovk pushed a commit that referenced this pull request Oct 21, 2025
@miss-islington@AA-Turner
[3.13]GH-139436: Remove references to downloadable PDF documentation (…
7b204ab
…GH-140416) (#140420) Co-authored-by: Adam Turner <[email protected]>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@AA-Turner@StanFromIreland
pythonGH-139436: Remove references to downloadable PDF documentation (p…
2f6f4e5
…ython#140416)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AA-Turner@hugovk