Skip to content

gh-130317: Fix SNaN broken tests on HP PA RISC#140452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 3 commits into from
Oct 22, 2025
Merged

gh-130317: Fix SNaN broken tests on HP PA RISC #140452

vstinner merged 3 commits into from
Oct 22, 2025

Conversation

@stefanor
Copy link
Contributor

@stefanorstefanor commented Oct 22, 2025•
edited by bedevere-app bot
Loading

While looking at #140028 I found some unrelated test regressions in the 3.14 cycle. These seem to all come from #130317. From what I can tell, that made Python more correct than it was before. According to 0 HP PA RISC uses 1 for SNaN and thus a 0 for QNaN.

Update tests to expect this.

@stefanor
Fix SNaN broken tests on HP PA RISC
96815eb
While looking at python#140028 I found some unrelated test regressions in the 3.14 cycle. These seem to all come from python#130317. From what I can tell, that made Python more correct than it was before. According to [0] HP PA RISC uses 1 for SNaN and thus a 0 for QNaN. Update tests to expect this. [0]: https://grouper.ieee.org/groups/1788/email/msg03272.html
@bedevere-appbedevere-appbot added tests Tests in the Lib/test dir awaiting review labels Oct 22, 2025
@stefanor
Copy link
ContributorAuthor

stefanor commented Oct 22, 2025

FYI: @thesamesam

@skirpichevskirpichev self-requested a review October 22, 2025 11:17
@skirpichevskirpichev changed the title Fix SNaN broken tests on HP PA RISCgh-130317: Fix SNaN broken tests on HP PA RISCOct 22, 2025
@bedevere-appbedevere-appbot mentioned this pull request Oct 22, 2025
Closed
skirpichev
skirpichev reviewed Oct 22, 2025
View reviewed changes
skirpichev
skirpichev reviewed Oct 22, 2025
View reviewed changes
@skirpichevskirpichev added the needs backport to 3.14 bugs and security fixes label Oct 22, 2025
@skirpichev
Copy link
Member

skirpichev commented Oct 22, 2025

CC @vstinner

skirpichev
skirpichev approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@skirpichevskirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nitpicks

vstinner
vstinner approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinnervstinner merged commit 76fea55 into python:mainOct 22, 2025
47 checks passed
@miss-islington-app
Copy link

miss-islington-appbot commented Oct 22, 2025

Thanks @stefanor for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2025
@stefanor@miss-islington
pythongh-130317: Fix SNaN broken tests on HP PA RISC (pythonGH-140452)
fe6f7fd
While looking at pythonGH-140028, I found some unrelated test regressions in the 3.14 cycle. These seem to all come from pythonGH-130317. From what I can tell, that made Python more correct than it was before. According to [0], HP PA RISC uses 1 for SNaN and thus a 0 for QNaN. [0]: https://grouper.ieee.org/groups/1788/email/msg03272.html (cherry picked from commit 76fea55) Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
@stefanorstefanor deleted the hppa-quiet-nans branch October 22, 2025 16:36
@bedevere-app
Copy link

bedevere-appbot commented Oct 22, 2025

GH-140467 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Oct 22, 2025
@vstinner
Copy link
Member

vstinner commented Oct 22, 2025

Merged, thanks.

vstinner pushed a commit that referenced this pull request Oct 22, 2025
@miss-islington@stefanor
[3.14]gh-130317: Fix SNaN broken tests on HP PA RISC (GH-140452) (#1…
853e5d9
…40467) gh-130317: Fix SNaN broken tests on HP PA RISC (GH-140452) While looking at GH-140028, I found some unrelated test regressions in the 3.14 cycle. These seem to all come from GH-130317. From what I can tell, that made Python more correct than it was before. According to [0], HP PA RISC uses 1 for SNaN and thus a 0 for QNaN. [0]: https://grouper.ieee.org/groups/1788/email/msg03272.html (cherry picked from commit 76fea55) Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@stefanor@StanFromIreland
pythongh-130317: Fix SNaN broken tests on HP PA RISC (python#140452)
f839c45
While looking at python#140028, I found some unrelated test regressions in the 3.14 cycle. These seem to all come from python#130317. From what I can tell, that made Python more correct than it was before. According to [0], HP PA RISC uses 1 for SNaN and thus a 0 for QNaN. [0]: https://grouper.ieee.org/groups/1788/email/msg03272.html
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@skirpichevskirpichevskirpichev approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stefanor@skirpichev@vstinner