gh-140544: cleanup HAVE_THREAD_LOCAL checks in pystate.c#140547
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kumaraditya303 requested review from ZeroIntensity and ericsnowcurrently as code owners
corona10 approved these changes Oct 24, 2025
ZeroIntensity approved these changes Oct 24, 2025
Member
ZeroIntensity left a comment
ZeroIntensity left a comment There was a problem hiding this comment.
I'm a little worried about the rationale expressed in the issue, but I think we should do this anyway.
Member
corona10 commented Oct 24, 2025
Yeah, I feel the same way. |
ContributorAuthor
kumaraditya303 commented Oct 24, 2025
Yeah, this cleanup is orthogonal to the issue but still seems good to clean this up a bit. |
kumaraditya303 merged commit ebf9938 into python:main 85 of 87 checks passed
Uh oh!
There was an error while loading. Please reload this page.
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for storing interpreter state as thread-local variable.
The GIL state functions such as
gilstate_getalready access_Py_tss_gilstateunconditionally so rather than adding this check everywhere, it is added in the beginning of the file now.