gh-140729: Add __mp_main as a duplicate for main__ for pickle to work#140735

yihong0618 · 2025-10-29T03:37:31Z

the fix is like gaogaotiantian/viztracer#423 viztracer fix

Issue: 3.15 profiling, can't use ProcessPoolExecutor.map() in a simple script #140729

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

yihong0618 · 2025-10-29T06:53:29Z

test failed is flaky

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

Lib/test/test_profiling/test_sampling_profiler.py

pablogsal · 2025-11-01T17:14:11Z

Misc/NEWS.d/next/Core_and_Builtins/2025-10-29-11-31-59.gh-issue-140729.t9JsNt.rst

@@ -0,0 +1,2 @@
+Fix: Add __mp_main__ as a duplicate for __main__ for pickle to work in


This needs to refer the profiler otherwise is not possible to undestand what this is fixing. Also this should say WHAT is fixed not HOW

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

yihong0618 · 2025-11-02T00:12:38Z

Do not know why windows free thread failed root cause, will go to find a windows test it these days.

pablogsal · 2025-11-02T01:09:48Z

Do not know why windows free thread failed root cause, will go to find a windows test it these days.

It seems there is some kind of race condition because the other windows test failed with a timeout

pablogsal · 2025-11-02T01:10:55Z

Lib/test/test_profiling/test_sampling_profiler.py

+withSuppressCrashReport():
+withscript_helper.spawn_python(
+"-m", "profiling.sampling.sample",
+"-d", "1",


You probaby need to sample for more time in case the machine is slow

check other code in the test use 5 now

pablogsal · 2025-11-02T01:11:09Z

Lib/test/test_profiling/test_sampling_profiler.py

+stderr=subprocess.PIPE,
+text=True
+ ) asproc:
+proc.wait(timeout=10)


Use SHORT_TIMEOUT from support (you are already importing it)

Lib/profiling/sampling/_sync_coordinator.py

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

yihong0618 · 2025-11-02T01:54:01Z

Do not know why windows free thread failed root cause, will go to find a windows test it these days.
It seems there is some kind of race condition because the other windows test failed with a timeout

passed now, thank you very much, learned that

bedevere-bot · 2025-11-03T21:29:07Z

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 59c1c1d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140735%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

YvesDup · 2025-11-04T13:11:45Z

Regarding our recent discussions, could you add the fix about the cProfile module and a test ?

yihong0618 · 2025-11-04T13:50:54Z

Regarding our recent discussions, could you add the fix about the cProfiler module and a test ?

sorry for the comment, I think we should not fix it here

I we should not fix this issue on the profile module indeed

yihong0618 · 2025-11-17T09:20:45Z

conflict fixed

pablogsal · 2025-11-17T12:43:11Z

Amazing! Thanks a lot for the great work @yihong0618 🚀

yihong0618 · 2025-11-17T12:44:07Z

Amazing! Thanks a lot for the great work @yihong0618 🚀

thank you very much!

…le to work (python#140735)

fix: Add __mp_main__ as a duplicate for __main__ for pickle to work
0c858f9
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

bedevere-appbot added the awaiting review label Oct 29, 2025

yihong0618 changed the title ~~fix: Add __mp_main__ as a duplicate for __main__ for pickle to work~~gh-140729: Add __mp_main__ as a duplicate for __main__ for pickle to workOct 29, 2025

bedevere-appbot mentioned this pull request Oct 29, 2025
3.15 profiling, can't use ProcessPoolExecutor.map() in a simple script #140729
Closed

yihong0618 added 4 commits October 29, 2025 11:56

fix: skip the test if no permission
4cc0482
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

fix: temp file leak
08de5c3
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

fix: make test better
e9bd308
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

fix: drop comments
285a66f
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

yihong0618 added 2 commits October 29, 2025 14:59

Merge branch 'main' into hy/close_issue_140729
c4b5152

fix: merge main fix conflict
9c6c76b
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

pablogsal reviewed Nov 1, 2025
View reviewed changes

Lib/test/test_profiling/test_sampling_profiler.pyShow resolvedHide resolved

pablogsal reviewed Nov 1, 2025
View reviewed changes

fix: apply suggestions
8b93ec3
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

yihong0618 requested a review from pablogsal November 1, 2025 22:43

fix: ensure flush that free thread on windows will not flush
c2e66dd
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

pablogsal reviewed Nov 2, 2025
View reviewed changes

Lib/profiling/sampling/_sync_coordinator.py Outdated Show resolvedHide resolved

pablogsal reviewed Nov 2, 2025
View reviewed changes

Lib/profiling/sampling/_sync_coordinator.py Outdated Show resolvedHide resolved

fix: apply suggestions and drop noise code
59c1c1d
Signed-off-by: yihong0618 <zouzou0208@gmail.com>

yihong0618 requested a review from pablogsal November 2, 2025 01:54

pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 3, 2025

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 3, 2025

Merge branch 'main' into hy/close_issue_140729
eda012e

pablogsal approved these changes Nov 17, 2025
View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting review labels Nov 17, 2025

pablogsal merged commit 994ab5c into python:mainNov 17, 2025
50 checks passed

bedevere-appbot removed the awaiting merge label Nov 17, 2025

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-140729: Add __mp_main__ as a duplicate for __main__ for pick…
ebf9382
…le to work (python#140735)

		@@ -0,0 +1,2 @@
		Fix: Add __mp_main__ as a duplicate for __main__ for pickle to work in

Uh oh!

gh-140729: Add __mp_main__ as a duplicate for __main__ for pickle to work#140735

gh-140729: Add __mp_main__ as a duplicate for __main__ for pickle to work #140735

Uh oh!

Conversation

yihong0618 commented Oct 29, 2025• edited by bedevere-app botLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yihong0618 commented Oct 29, 2025

Uh oh!

Uh oh!

pablogsalNov 1, 2025

Choose a reason for hiding this comment

Uh oh!

yihong0618Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

yihong0618 commented Nov 2, 2025

Uh oh!

pablogsal commented Nov 2, 2025

Uh oh!

pablogsalNov 2, 2025

Choose a reason for hiding this comment

Uh oh!

yihong0618Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

yihong0618Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

pablogsalNov 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yihong0618 commented Nov 2, 2025

Uh oh!

bedevere-bot commented Nov 3, 2025

Uh oh!

YvesDup commented Nov 4, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yihong0618 commented Nov 4, 2025

Uh oh!

yihong0618 commented Nov 17, 2025

Uh oh!

pablogsal commented Nov 17, 2025

Uh oh!

Uh oh!

yihong0618 commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-140729: Add __mp_main as a duplicate for main__ for pickle to work#140735

gh-140729: Add __mp_main as a duplicate for main__ for pickle to work #140735

yihong0618 commented Oct 29, 2025•
edited by bedevere-app bot
Loading

pablogsalNov 2, 2025•
edited
Loading

YvesDup commented Nov 4, 2025•
edited
Loading