Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commented Nov 3, 2025

It is already accounted for in the other path:

if (dict&& (argidx<arglen)){
PyErr_SetString(PyExc_TypeError,
"not all arguments converted during bytes formatting");
Py_XDECREF(temp);
goto error;
}

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303kumaraditya303 added type-bug An unexpected behavior, bug, or error needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 6, 2025
@kumaraditya303kumaraditya303 merged commit d6c89a2 into python:mainNov 6, 2025
56 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @StanFromIreland and @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d6c89a2df2c8b7603125883494e9058a88348f66 3.14 

@miss-islington-app
Copy link

Sorry, @StanFromIreland and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d6c89a2df2c8b7603125883494e9058a88348f66 3.13 

@StanFromIrelandStanFromIreland deleted the bytes-leak branch November 6, 2025 07:22
@StanFromIreland
Copy link
MemberAuthor

I can backport.

@StanFromIrelandStanFromIreland self-assigned this Nov 6, 2025
@bedevere-app
Copy link

GH-141154 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Nov 6, 2025
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Nov 6, 2025
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Nov 6, 2025
@bedevere-app
Copy link

GH-141155 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Nov 6, 2025
vstinner pushed a commit that referenced this pull request Nov 6, 2025
vstinner pushed a commit that referenced this pull request Nov 6, 2025
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bugAn unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland@vstinner@kumaraditya303@RenaudBernier