gh-137969: Fix double evaluation of `ForwardRef`s which rely on globals#140974

dr-carlos · 2025-11-04T05:26:31Z

Implements the same fix as gh-137969: Fix evaluation of ref.evaluate(format=Format.FORWARDREF) objects #138075, but just adds new locals (without overwriting the actual locals), instead of using a new dictionary.
Takes the same approach with the new __cell__ nonlocal variables added to globals in gh-138151: Fix annotationlib handling of multiple nonlocals #138164
Includes a test which doesn't shadow other variable names with a global declaration and resets across test runs (this broke buildbots last time).

Issue: annotationlib: ref.evaluate(format=Format.FORWARDREF) returns a ForwardRef with a copied __globals__ that no longer updates #137969

…works

Lib/annotationlib.py

JelleZijlstra

Thanks! Could you also add a unit test asserting that if a locals dictionary is passed in, it's not modified?

Lib/annotationlib.py

Lib/test/test_annotationlib.py

This reverts commit 2630802.

dr-carlos · 2025-11-06T12:04:02Z

Thanks! Could you also add a unit test asserting that if a locals dictionary is passed in, it's not modified?

Added one to test globals and locals, since they're both dicts which are mutable.

miss-islington-app · 2025-11-13T18:17:21Z

Thanks @dr-carlos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

… globals (pythonGH-140974) (cherry picked from commit 209eaff) Co-authored-by: dr-carlos <[email protected]>

bedevere-app · 2025-11-13T18:17:29Z

GH-141527 is a backport of this pull request to the 3.14 branch.

bedevere-bot · 2025-11-13T18:46:55Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit 209eaff.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/12676) and take a look at the build logs.
Check if the failure is related to this commit (209eaff) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/12676

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last): File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 847, in gc_collect gc.collect() ~~~~~~~~~~^^ResourceWarning: unclosed file <_io.FileIO name=13 mode='wb' closefd=True> Traceback (most recent call last): File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 847, in gc_collect gc.collect() ~~~~~~~~~~^^ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>

dr-carlos · 2025-11-13T20:42:41Z

Traceback (mostrecentcalllast): File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line847, ingc_collectgc.collect() ~~~~~~~~~~^^ResourceWarning: unclosedfile<_io.FileIOname=13mode='wb'closefd=True>Traceback (mostrecentcalllast): File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line847, ingc_collectgc.collect() ~~~~~~~~~~^^ResourceWarning: unclosedfile<_io.FileIOname=11mode='wb'closefd=True>

Seems like a completely unrelated error, annotationlib doesn't explicitly deal with files.

* main: (463 commits) pythongh-140601: Add ResourceWarning to iterparse when not closed (pythonGH-140603) pythongh-137969: Fix double evaluation of `ForwardRef`s which rely on globals (python#140974) pythongh-139109: A new tracing JIT compiler frontend for CPython (pythonGH-140310) pythongh-141004: Document `PyErr_RangedSyntaxLocationObject` (python#141521) pythongh-140873: Add support of non-descriptor callables in functools.singledispatchmethod() (pythonGH-140884) pythongh-139653: Add PyUnstable_ThreadState_SetStackProtection() (python#139668) pythongh-141004: Document `PyCode_Optimize` (pythonGH-141378) pythongh-141004: Document C APIs for dictionary keys, values, and items (pythonGH-141009) pythongh-137959: Fix `TIER1_TO_TIER2` macro name in JIT InternalDocs (pythonGH-141496) pythongh-139871: Add `bytearray.take_bytes([n])` to efficiently extract `bytes` (pythonGH-140128) pythongh-140601: Refactor ElementTree.iterparse() tests (pythonGH-141499) pythongh-135801: Add the module parameter to compile() etc (pythonGH-139652) pythongh-140260: fix data race in `_struct` module initialization with subinterpreters (python#140909) pythongh-137109: refactor warning about threads when forking (python#141438) pythongh-141004: Document `PyRun_InteractiveOneObject` (pythonGH-141405) pythongh-124111: Fix TCL 9 thread detection (pythonGH-128103) pythongh-141442: Add escaping to iOS testbed arguments (python#141443) pythongh-140936: Fix JIT assertion crash at finalization if some generator is alive (pythonGH-140969) Add details about JIT build infrastructure and updating dependencies to `Tools/jit` (python#141167) pythongh-141412: Use reliable target URL for urllib example (pythonGH-141428) ...

…n globals (GH-140974) (#141527) gh-137969: Fix double evaluation of `ForwardRef`s which rely on globals (GH-140974) (cherry picked from commit 209eaff) Co-authored-by: dr-carlos <[email protected]>

bedevere-bot · 2025-11-13T22:04:27Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.14 (tier-2) has failed when building commit dd28db6.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1772/builds/707) and take a look at the build logs.
Check if the failure is related to this commit (dd28db6) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1772/builds/707

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect gc.collect() ResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 60536), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 60542), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect gc.collect() ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 60542), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 60548), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect gc.collect() ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 60548), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 60556), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect gc.collect() ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 60556), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect gc.collect() ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 60584), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 60590), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect gc.collect() ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 60590), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 60597), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect gc.collect() ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 60597), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 60603), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in gc_collect gc.collect() ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 60603), raddr=('68.183.26.59', 21)> Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 60580), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 60582), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 60582), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 60592), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 60595), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 60595), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 60599), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=11, family=2, type=1, proto=6, laddr=('192.168.0.101', 60601), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=11, family=2, type=1, proto=6, laddr=('192.168.0.101', 60601), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 60532), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 60534), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 60534), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 60550), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=11, family=2, type=1, proto=6, laddr=('192.168.0.101', 60554), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=11, family=2, type=1, proto=6, laddr=('192.168.0.101', 60554), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 60538), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 60540), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 60540), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 60586), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 60588), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 60588), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available" Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 60544), raddr=('68.183.26.59', 21)> Warning -- Unraisable exception Exception ignored while finalizing socket <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 60546), raddr=('68.183.26.59', 21)>: Traceback (most recent call last): File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_urllib2net.py", line 22, in _retry_thrice last_exc = e ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 60546), raddr=('68.183.26.59', 21)> skipped "Resource 'ftp://www.pythontest.net/' is not available"

JelleZijlstra · 2025-11-13T22:06:59Z

urllib2net stuff, Petr is working I believe on disabling those.

* 'main' of github.com:python/cpython: (464 commits) pythongh-140601: Add ResourceWarning to iterparse when not closed (pythonGH-140603) pythongh-137969: Fix double evaluation of `ForwardRef`s which rely on globals (python#140974) pythongh-139109: A new tracing JIT compiler frontend for CPython (pythonGH-140310) pythongh-141004: Document `PyErr_RangedSyntaxLocationObject` (python#141521) pythongh-140873: Add support of non-descriptor callables in functools.singledispatchmethod() (pythonGH-140884) pythongh-139653: Add PyUnstable_ThreadState_SetStackProtection() (python#139668) pythongh-141004: Document `PyCode_Optimize` (pythonGH-141378) pythongh-141004: Document C APIs for dictionary keys, values, and items (pythonGH-141009) pythongh-137959: Fix `TIER1_TO_TIER2` macro name in JIT InternalDocs (pythonGH-141496) pythongh-139871: Add `bytearray.take_bytes([n])` to efficiently extract `bytes` (pythonGH-140128) pythongh-140601: Refactor ElementTree.iterparse() tests (pythonGH-141499) pythongh-135801: Add the module parameter to compile() etc (pythonGH-139652) pythongh-140260: fix data race in `_struct` module initialization with subinterpreters (python#140909) pythongh-137109: refactor warning about threads when forking (python#141438) pythongh-141004: Document `PyRun_InteractiveOneObject` (pythonGH-141405) pythongh-124111: Fix TCL 9 thread detection (pythonGH-128103) pythongh-141442: Add escaping to iOS testbed arguments (python#141443) pythongh-140936: Fix JIT assertion crash at finalization if some generator is alive (pythonGH-140969) Add details about JIT build infrastructure and updating dependencies to `Tools/jit` (python#141167) pythongh-141412: Use reliable target URL for urllib example (pythonGH-141428) ...

bedevere-bot · 2025-11-14T00:12:16Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Refleaks 3.14 (tier-3) has failed when building commit dd28db6.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1800/builds/690) and take a look at the build logs.
Check if the failure is related to this commit (dd28db6) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1800/builds/690

Failed tests:

test.test_concurrent_futures.test_interpreter_pool

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last): File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 847, in gc_collect gc.collect() ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True> .test_cancel_make_subprocess_transport_exec (test.test_asyncio.test_subprocess.SubprocessPidfdWatcherTests.test_cancel_make_subprocess_transport_exec) ... skipped 'operating system does not support pidfds' Traceback (most recent call last): File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/concurrent/futures/thread.py", line 99, in _worker ctx.initialize() ~~~~~~~~~~~~~~^^ File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/concurrent/futures/interpreter.py", line 61, in initializeself.interp = interpreters.create() ~~~~~~~~~~~~~~~~~~~^^ File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/concurrent/interpreters/__init__.py", line 65, in createid= _interpreters.create(reqrefs=True) concurrent.interpreters.InterpreterError: interpreter creation failed Timeout (0:45:00)! Thread 0x0000000843371900 [InterpreterPoolExec] (most recent call first): File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/concurrent/interpreters/__init__.py", line 220 in _call File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/concurrent/interpreters/__init__.py", line 238 in call File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/concurrent/futures/interpreter.py", line 84 in run File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/concurrent/futures/thread.py", line 86 in run File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/concurrent/futures/thread.py", line 119 in _worker File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/threading.py", line 1024 in run File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/threading.py", line 1082 in _bootstrap_inner File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/threading.py", line 1044 in _bootstrap Traceback (most recent call last): File "<frozen importlib._bootstrap>", line 1371, in _find_and_load File "<frozen importlib._bootstrap>", line 1333, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 1267, in _find_spec File "<frozen importlib._bootstrap_external>", line 1296, in find_spec File "<frozen importlib._bootstrap_external>", line 1270, in _get_spec File "<frozen importlib._bootstrap_external>", line 1388, in find_spec File "<frozen importlib._bootstrap_external>", line 166, in _path_isfile File "<frozen importlib._bootstrap_external>", line 158, in _path_is_mode_type File "<frozen importlib._bootstrap_external>", line 152, in _path_statValueError: embedded null byte Exception in initializer: RuntimeError: Failed to import encodings module Traceback (most recent call last): File "/buildbot/buildarea/3.14.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 847, in gc_collect gc.collect() ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True> .test_cancel_make_subprocess_transport_exec (test.test_asyncio.test_subprocess.SubprocessPidfdWatcherTests.test_cancel_make_subprocess_transport_exec) ... skipped 'operating system does not support pidfds'

* 'main' of github.com:python/cpython: (464 commits) pythongh-140601: Add ResourceWarning to iterparse when not closed (pythonGH-140603) pythongh-137969: Fix double evaluation of `ForwardRef`s which rely on globals (python#140974) pythongh-139109: A new tracing JIT compiler frontend for CPython (pythonGH-140310) pythongh-141004: Document `PyErr_RangedSyntaxLocationObject` (python#141521) pythongh-140873: Add support of non-descriptor callables in functools.singledispatchmethod() (pythonGH-140884) pythongh-139653: Add PyUnstable_ThreadState_SetStackProtection() (python#139668) pythongh-141004: Document `PyCode_Optimize` (pythonGH-141378) pythongh-141004: Document C APIs for dictionary keys, values, and items (pythonGH-141009) pythongh-137959: Fix `TIER1_TO_TIER2` macro name in JIT InternalDocs (pythonGH-141496) pythongh-139871: Add `bytearray.take_bytes([n])` to efficiently extract `bytes` (pythonGH-140128) pythongh-140601: Refactor ElementTree.iterparse() tests (pythonGH-141499) pythongh-135801: Add the module parameter to compile() etc (pythonGH-139652) pythongh-140260: fix data race in `_struct` module initialization with subinterpreters (python#140909) pythongh-137109: refactor warning about threads when forking (python#141438) pythongh-141004: Document `PyRun_InteractiveOneObject` (pythonGH-141405) pythongh-124111: Fix TCL 9 thread detection (pythonGH-128103) pythongh-141442: Add escaping to iOS testbed arguments (python#141443) pythongh-140936: Fix JIT assertion crash at finalization if some generator is alive (pythonGH-140969) Add details about JIT build infrastructure and updating dependencies to `Tools/jit` (python#141167) pythongh-141412: Use reliable target URL for urllib example (pythonGH-141428) ...

… globals (python#140974)

dr-carlos added 4 commits November 4, 2025 15:23

Extract type param scope instead of copying globals dict
8708272

Add test for re-evaluating ForwardRef generics
fc00d21

Simplify scope logic in ref.evaluate() to ensure double-evaluation …
71c9074
…works

Add NEWS entry
1c79ac7

dr-carlos requested a review from JelleZijlstra as a code owner November 4, 2025 05:26

bedevere-appbot added the awaiting review label Nov 4, 2025

bedevere-appbot mentioned this pull request Nov 4, 2025
annotationlib: ref.evaluate(format=Format.FORWARDREF) returns a ForwardRef with a copied __globals__ that no longer updates #137969
Open

Update del to end of test_re_evaluate_generics
2630802

JelleZijlstra reviewed Nov 4, 2025
View reviewed changes

Lib/annotationlib.py Outdated Show resolvedHide resolved

Create new locals dict when necessary
d02e635

JelleZijlstra added the needs backport to 3.14 bugs and security fixes label Nov 6, 2025

JelleZijlstra reviewed Nov 6, 2025
View reviewed changes

Lib/annotationlib.py Outdated Show resolvedHide resolved
Lib/annotationlib.py Outdated Show resolvedHide resolved
Lib/test/test_annotationlib.py Outdated Show resolvedHide resolved

dr-carlos added 3 commits November 6, 2025 22:02

Revert "Update del to end of test_re_evaluate_generics"
02b8a83
This reverts commit 2630802.

Use locals.setdefault() instead of manually checking if key in dict
e20da27

Add test to check if arguments to ref.evaluate() are mutated
65c40d3

Include less code within cell.cell_contents try-except block
41c3e64

dr-carlos mentioned this pull request Nov 13, 2025
annotationlib: Improve test coverage #141174
Open

JelleZijlstra approved these changes Nov 13, 2025
View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting review labels Nov 13, 2025

Merge branch 'main' into fwdref-double-eval
f457725

JelleZijlstra enabled auto-merge (squash) November 13, 2025 17:40

JelleZijlstra merged commit 209eaff into python:mainNov 13, 2025
46 checks passed

bedevere-appbot removed the awaiting merge label Nov 13, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2025
pythongh-137969: Fix double evaluation ofForwardRefs which rely on…
2d7525c
… globals (pythonGH-140974) (cherry picked from commit 209eaff) Co-authored-by: dr-carlos <[email protected]>

bedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Nov 13, 2025

dr-carlos deleted the fwdref-double-eval branch November 13, 2025 20:42

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-137969: Fix double evaluation ofForwardRefs which rely on…
f84043b
… globals (python#140974)

Uh oh!

gh-137969: Fix double evaluation of ForwardRefs which rely on globals#140974

gh-137969: Fix double evaluation of ForwardRefs which rely on globals #140974

Uh oh!

Conversation

dr-carlos commented Nov 4, 2025• edited by bedevere-app botLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JelleZijlstra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dr-carlos commented Nov 6, 2025

Uh oh!

Uh oh!

miss-islington-appbot commented Nov 13, 2025

Uh oh!

bedevere-appbot commented Nov 13, 2025

Uh oh!

bedevere-bot commented Nov 13, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

dr-carlos commented Nov 13, 2025

Uh oh!

bedevere-bot commented Nov 13, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

JelleZijlstra commented Nov 13, 2025

Uh oh!

bedevere-bot commented Nov 14, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-137969: Fix double evaluation of `ForwardRef`s which rely on globals#140974

gh-137969: Fix double evaluation of `ForwardRef`s which rely on globals #140974

dr-carlos commented Nov 4, 2025•
edited by bedevere-app bot
Loading