Skip to content

Conversation

@ZeroIntensity
Copy link
Member

@ZeroIntensityZeroIntensity commented Nov 4, 2025

@encukou
Copy link
Member

I think all of the type objects should be soft-deprecated. They're not very useful, and making them public API makes it hard to convert them to heap types. Also, PyRangeIter_Type/PyLongRangeIter_Type exposes too much an implementation detail.
Could you check with the C API WG?

@ZeroIntensity
Copy link
MemberAuthor

All the iterator type objects, or all the type objects in #141004?

Could you check with the C API WG?

Will do.

Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Two things to consider, but if you like the current PR I'm happy with it too:

@ZeroIntensity
Copy link
MemberAuthor

I like the table idea a lot. I went with that.

@ZeroIntensityZeroIntensity merged commit 1697cb5 into python:mainNov 6, 2025
28 checks passed
@ZeroIntensityZeroIntensity deleted the document-missing-types branch November 6, 2025 12:29
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsNov 6, 2025
@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2025
…nGH-141006) Adds documentation for each of the following: - PyEnum_Type - PyFilter_Type - PyMap_Type - PyReversed_Type - PyZip_Type In addition, PyRange_Type and PyRange_Check are also documented. (cherry picked from commit 1697cb5) Co-authored-by: Peter Bierma <[email protected]>
@bedevere-app
Copy link

GH-141134 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Nov 6, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2025
…nGH-141006) Adds documentation for each of the following: - PyEnum_Type - PyFilter_Type - PyMap_Type - PyReversed_Type - PyZip_Type In addition, PyRange_Type and PyRange_Check are also documented. (cherry picked from commit 1697cb5) Co-authored-by: Peter Bierma <[email protected]>
@bedevere-app
Copy link

GH-141135 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Nov 6, 2025
ZeroIntensity added a commit that referenced this pull request Nov 6, 2025
…41006) (GH-141134) gh-141004: Document built-in iterator types in the C API (GH-141006) Adds documentation for each of the following: - PyEnum_Type - PyFilter_Type - PyMap_Type - PyReversed_Type - PyZip_Type In addition, PyRange_Type and PyRange_Check are also documented. (cherry picked from commit 1697cb5) Co-authored-by: Peter Bierma <[email protected]>
ZeroIntensity added a commit that referenced this pull request Nov 6, 2025
…41006) (GH-141135) gh-141004: Document built-in iterator types in the C API (GH-141006) Adds documentation for each of the following: - PyEnum_Type - PyFilter_Type - PyMap_Type - PyReversed_Type - PyZip_Type In addition, PyRange_Type and PyRange_Check are also documented. (cherry picked from commit 1697cb5) Co-authored-by: Peter Bierma <[email protected]>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
…nGH-141006) Adds documentation for each of the following: - PyEnum_Type - PyFilter_Type - PyMap_Type - PyReversed_Type - PyZip_Type In addition, PyRange_Type and PyRange_Check are also documented.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroIntensity@encukou