gh-141004: soft-deprecate Py_INFINITY macro#141033
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
skirpichev commented Nov 5, 2025
Waiting for feedback in the issue thread. I'm planning soft-deprecate also Py_NAN. |
vstinner reviewed Nov 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <[email protected]>
MemberAuthor
skirpichev commented Nov 6, 2025
I'll add docs here too. |
ZeroIntensity approved these changes Nov 6, 2025
Member
ZeroIntensity left a comment
ZeroIntensity left a comment There was a problem hiding this comment.
I don't have much of an opinion here, I think this is fine. Would you mind creating a PR for <3.15 documenting this without the deprecation?
Member
ZeroIntensity commented Nov 6, 2025
(Let's also wait on the C API WG before landing this one.) |
MemberAuthor
skirpichev commented Nov 6, 2025
See #141145. |
skirpichev commented Nov 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
vstinner merged commit e202673 into python:main 46 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Member
vstinner commented Nov 12, 2025
Merged, thank you. |
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Co-authored-by: Victor Stinner <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--141033.org.readthedocs.build/