gh-141004: Document PyODict* APIs#141136
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bedevere-appbot added awaiting core review docs 
Doc/c-api/dict.rst Outdated
Comment on lines 461 to 462
| Return true if *od* is a dict object, but not an instance of a subtype of | ||
| the :class:`~collections.OrderedDict` type. This function always succeeds. |
There was a problem hiding this comment.
Suggested change
| Return true if *od* is a dict object, but not an instance of a subtype of | |
| the :class:`~collections.OrderedDict` type. This function always succeeds. | |
| Return true if *od* is an ordered dictionary object, but not | |
| an instance of a subtype of the :class:`~collections.OrderedDict` type. | |
| This function always succeeds. |
- a dict object+ an ordered dictionary objectMemberAuthor
There was a problem hiding this comment.
Applied this one locally because I didn't want to deal with conflicts.
Doc/c-api/dict.rst Outdated
Comment on lines 448 to 449
| Since Python 3.7, dictionaries are ordered by default, so there is usually | ||
| little need for this object. |
There was a problem hiding this comment.
I suggest moving this to the introductory paragraph.
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
ZeroIntensity commented Nov 12, 2025
I'd like to finish #141009 before doing this one. |
These are documented now so we can link to them.
ZeroIntensity added needs backport to 3.13 ZeroIntensity merged commit b362632 into python:main 30 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2025
(cherry picked from commit b362632) Co-authored-by: Peter Bierma <[email protected]>
GH-141677 is a backport of this pull request to the 3.14 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2025
(cherry picked from commit b362632) Co-authored-by: Peter Bierma <[email protected]>
GH-141678 is a backport of this pull request to the 3.13 branch. |
ZeroIntensity added a commit that referenced this pull request Nov 17, 2025
ZeroIntensity added a commit that referenced this pull request Nov 17, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--141136.org.readthedocs.build/en/141136/c-api/dict.html#ordered-dictionaries