gh-141174: Improve ForwardRef test coverage#141175
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JelleZijlstra merged commit 19b5730 into python:main 50 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @dr-carlos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Thanks @dr-carlos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
* Test unsupported format in ForwardRef.evaluate() * Test dict cell closure with multiple variables * Test all options in ForwardRef repr * Test ForwardRef being a final class (cherry picked from commit 19b5730) Co-authored-by: dr-carlos <77367421+dr-carlos@users.noreply.github.com>
GH-141354 is a backport of this pull request to the 3.14 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
* Test unsupported format in ForwardRef.evaluate() * Test dict cell closure with multiple variables * Test all options in ForwardRef repr * Test ForwardRef being a final class (cherry picked from commit 19b5730) Co-authored-by: dr-carlos <77367421+dr-carlos@users.noreply.github.com>
Sorry @dr-carlos and @JelleZijlstra, I had trouble completing the backport. |
JelleZijlstra pushed a commit that referenced this pull request Nov 10, 2025
…1354) gh-141174: Improve `ForwardRef` test coverage (GH-141175) * Test unsupported format in ForwardRef.evaluate() * Test dict cell closure with multiple variables * Test all options in ForwardRef repr * Test ForwardRef being a final class (cherry picked from commit 19b5730) Co-authored-by: dr-carlos <77367421+dr-carlos@users.noreply.github.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
* Test unsupported format in ForwardRef.evaluate() * Test dict cell closure with multiple variables * Test all options in ForwardRef repr * Test ForwardRef being a final class
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All lines in the
ForwardRefclass (except_evaluate) should now be covered by tests, exceptcpython/Lib/annotationlib.py
Lines 146 to 147 in 42d0140
I couldn't think of a useful test for those lines that wouldn't involve using the undocumented
ForwardRefconstructor (as the owner is automatically applied byannotationlib.get_annotations()).