Skip to content

Conversation

@ZeroIntensity
Copy link
Member

@ZeroIntensityZeroIntensity commented Nov 9, 2025

Comment on lines +107 to +108
Set the keyword-only argument default values of the function object *op*.
*defaults* must be a dictionary of keyword-only arguments or ``Py_None``.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Set the keyword-only argument default values of the function object *op*.
*defaults* must be a dictionary of keyword-only arguments or ``Py_None``.
Set the keyword-only parameter default values of the function object *op*.
*defaults* must be a dictionary of keyword-only parameters or ``Py_None``.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We say "argument" everywhere else in this file, so I'd rather not deviate from it here. I don't think that the distinction is particularly helpful for readers here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of such a precedent, but unfortunately it is. Fixing this is tracked in #133438.

Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroIntensityZeroIntensity merged commit 18529b5 into python:mainNov 9, 2025
28 checks passed
@ZeroIntensityZeroIntensity deleted the document-set-kw-defaults branch November 9, 2025 17:49
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsNov 9, 2025
@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 9, 2025
@bedevere-app
Copy link

GH-141304 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Nov 9, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 9, 2025
@bedevere-app
Copy link

GH-141305 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Nov 9, 2025
ZeroIntensity added a commit that referenced this pull request Nov 9, 2025
…-141305) gh-141004: Document `PyFunction_SetKwDefaults` (GH-141294) (cherry picked from commit 18529b5) Co-authored-by: Peter Bierma <[email protected]>
ZeroIntensity added a commit that referenced this pull request Nov 9, 2025
…-141304) gh-141004: Document `PyFunction_SetKwDefaults` (GH-141294) (cherry picked from commit 18529b5) Co-authored-by: Peter Bierma <[email protected]>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroIntensity@StanFromIreland