Skip to content

gh-141004: Document Py_MATH_{E, PI, TAU} constants#141373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 3 commits into from
Nov 12, 2025
Merged

gh-141004: Document Py_MATH_{E, PI, TAU} constants #141373

vstinner merged 3 commits into from
Nov 12, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commented Nov 10, 2025•
edited
Loading

@bedevere-appbedevere-appbot added awaiting review docs Documentation in the Doc dir skip news labels Nov 10, 2025
@bedevere-appbedevere-appbot mentioned this pull request Nov 10, 2025
Open
vstinner
vstinner approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vstinner
vstinner reviewed Nov 10, 2025
View reviewed changes
skirpichev
skirpichev reviewed Nov 10, 2025
View reviewed changes
@vstinner
Copy link
Member

vstinner commented Nov 12, 2025

@StanFromIreland: Oh, there is now a merge conflict. Can you try to fix it?

@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Nov 12, 2025

Done :-)

@vstinnervstinner merged commit f1330b3 into python:mainNov 12, 2025
28 checks passed
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsNov 12, 2025
@StanFromIrelandStanFromIreland deleted the Py_MATH branch November 12, 2025 16:38
@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Nov 12, 2025

Thanks Victor and Sergey!

@vstinner
Copy link
Member

vstinner commented Nov 12, 2025

Merged, thanks.

@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Nov 12, 2025

Do we want to backport? These constants all exist on all bug-fix branches.

@vstinnervstinner added the needs backport to 3.14 bugs and security fixes label Nov 12, 2025
@miss-islington-app
Copy link

miss-islington-appbot commented Nov 12, 2025

Thanks @StanFromIreland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2025
@StanFromIreland@miss-islington
pythongh-141004: DocumentPy_MATH_{E, PI, TAU}constants (pythonGH-…
a25d7cf
…141373) (cherry picked from commit f1330b3) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-appbot commented Nov 12, 2025

GH-141471 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Nov 12, 2025
@vstinnervstinner added the needs backport to 3.13 bugs and security fixes label Nov 12, 2025
@miss-islington-app
Copy link

miss-islington-appbot commented Nov 12, 2025

Thanks @StanFromIreland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2025
@StanFromIreland@miss-islington
pythongh-141004: DocumentPy_MATH_{E, PI, TAU}constants (pythonGH-…
06223d4
…141373) (cherry picked from commit f1330b3) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-appbot commented Nov 12, 2025

GH-141472 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Nov 12, 2025
@vstinner
Copy link
Member

vstinner commented Nov 12, 2025

Do we want to backport? These constants all exist on all bug-fix branches.

Ok, I created backports to 3.13 and 3.14.

vstinner pushed a commit that referenced this pull request Nov 12, 2025
@miss-islington@StanFromIreland
[3.14]gh-141004: DocumentPy_MATH_{E, PI, TAU}constants (GH-141373)…
fe3826c
… (#141471) gh-141004: Document `Py_MATH_{E, PI, TAU}` constants (GH-141373) (cherry picked from commit f1330b3) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
vstinner pushed a commit that referenced this pull request Nov 12, 2025
@miss-islington@StanFromIreland
[3.13]gh-141004: DocumentPy_MATH_{E, PI, TAU}constants (GH-141373)…
7ca34db
… (#141472) gh-141004: Document `Py_MATH_{E, PI, TAU}` constants (GH-141373) (cherry picked from commit f1330b3) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@StanFromIreland
pythongh-141004: DocumentPy_MATH_{E, PI, TAU}constants (python#14…
1b7fec4
…1373)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@skirpichevskirpichevskirpichev approved these changes

@ZeroIntensityZeroIntensityAwaiting requested review from ZeroIntensity

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland@vstinner@skirpichev@ZeroIntensity