Skip to content

Conversation

@ZeroIntensity
Copy link
Member

@ZeroIntensityZeroIntensity commented Nov 11, 2025

Comment on lines 115 to 116
:c:expr:`const char*` that is decoded by the
:term:`filesystem encoding and error handler`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UTF-8 encoding, no (also implied by the parameter name)?

PyObject*pathobj=PyUnicode_FromString(utf8path);

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch.

Co-authored-by: Stan Ulbrych <[email protected]>
Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroIntensityZeroIntensity merged commit 2befce8 into python:mainNov 11, 2025
28 checks passed
@ZeroIntensityZeroIntensity deleted the document-pyfile branch November 11, 2025 20:31
@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsNov 11, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2025
…t` (pythonGH-141413) (cherry picked from commit 2befce8) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

GH-141425 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Nov 11, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2025
…t` (pythonGH-141413) (cherry picked from commit 2befce8) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

GH-141426 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Nov 11, 2025
ZeroIntensity added a commit that referenced this pull request Nov 11, 2025
…ct` (GH-141413) (GH-141425) gh-141004: Document `PyFile_OpenCode` and `PyFile_OpenCodeObject` (GH-141413) (cherry picked from commit 2befce8) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
ZeroIntensity added a commit that referenced this pull request Nov 11, 2025
…ct` (GH-141413) (GH-141426) gh-141004: Document `PyFile_OpenCode` and `PyFile_OpenCodeObject` (GH-141413) (cherry picked from commit 2befce8) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroIntensity@StanFromIreland