gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if needed #141785
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
encukou requested review from brettcannon, ericsnowcurrently, kumaraditya303, ncoghlan and warsaw as code owners
encukou commented Nov 20, 2025
| import tempfile | ||
| import types | ||
| _testsinglephase = import_helper.import_module("_testsinglephase") |
MemberAuthor
There was a problem hiding this comment.
_testsinglephase is unusable in subinterpreters.
encukou added the 🔨 test-with-buildbots 
bedevere-bot commented Nov 20, 2025
🤖 New build scheduled with the buildbot fleet by @encukou for commit 5b8b87c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141785%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot removed the 🔨 test-with-buildbots 
colesbury approved these changes Nov 20, 2025
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Sam Gross <[email protected]>
encukou merged commit bf66bce into python:main 46 checks passed
Uh oh!
There was an error while loading. Please reload this page.
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to enable GIL for the
PyModExport_function, which is supposed to do as little as possible before returning a static array.Py_MOD_GIL_USEDcan be handled at module creation time, without enabling it transiently first.The main difference from
PyModuleDef(i.e.import.c'simport_run_extension) is that hePy_mod_createfunction runs without the GIL enabled transiently. (It does run with GIL enabled permanently ifPy_MOD_GIL_USEDis specified -- same as thePy_mod_execfunction, which always runs after the EnableGILTransient block.)Also, if
Py_mod_createmakes a non-module object,Py_mod_gilis honored.@colesbury, does this look OK?
(The first commit has the change; the next
three7 are tests/docs)