Skip to content

Conversation

@SubbaraoGarlapati
Copy link
Contributor

test.support.import_helper in Lib/test/test_monitoring.py is not actually imported in the file, relying on another import to import it. As discussed in the previous pull request, this would be fine if importing test.support itself would import test.support.import_helper but that's not the case.

% python -c "import test.support; test.support.import_helper" Traceback (most recent call last): File "<string>", line 1, in <module> import test.support; test.support.import_helper ^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: module 'test.support' has no attribute 'import_helper' 

@bedevere-appbedevere-appbot added awaiting review tests Tests in the Lib/test dir labels Nov 20, 2025
@StanFromIrelandStanFromIreland changed the title Fix implicit importFix implicit import in test_monitoring.pyNov 20, 2025
@colesburycolesbury merged commit 369ce2b into python:mainNov 24, 2025
60 checks passed
@colesbury
Copy link
Contributor

Thanks!

@colesburycolesbury added the needs backport to 3.14 bugs and security fixes label Nov 24, 2025
@miss-islington-app
Copy link

Thanks @SubbaraoGarlapati for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2025
(cherry picked from commit 369ce2b) Co-authored-by: SubbaraoGarlapati <[email protected]>
@bedevere-app
Copy link

GH-141920 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Nov 24, 2025
colesbury pushed a commit that referenced this pull request Nov 24, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issueskip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SubbaraoGarlapati@colesbury@itamaro@StanFromIreland