Skip to content

gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT#141804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colesbury merged 1 commit into from
Nov 24, 2025
Merged

gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT #141804

colesbury merged 1 commit into from
Nov 24, 2025

Conversation

@colesbury
Copy link
Contributor

@colesburycolesbury commented Nov 20, 2025•
edited
Loading

@bedevere-appbedevere-appbot mentioned this pull request Nov 20, 2025
Closed
@colesburycolesbury marked this pull request as ready for review November 20, 2025 19:24
ayushHardeniya
ayushHardeniya approved these changes Nov 20, 2025
View reviewed changes
Copy link

@ayushHardeniyaayushHardeniya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

encukou
encukou approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Process nitpick: It would be nice to group this with the actual code change. Consider amending the title of gh-116749, attaching this PR to that, and marking gh-116329 as duplicate.

@colesburycolesbury changed the title gh-116329: Fix code comment for _PyConfig_GIL_DEFAULTgh-116749: Fix code comment for _PyConfig_GIL_DEFAULTNov 24, 2025
@bedevere-appbedevere-appbot mentioned this pull request Nov 24, 2025
Closed
@colesburycolesbury merged commit c490ffb into python:mainNov 24, 2025
52 checks passed
@colesburycolesbury deleted the _PyConfig_GIL_DEFAULT branch November 24, 2025 15:42
@colesburycolesbury added the needs backport to 3.14 bugs and security fixes label Nov 24, 2025
@miss-islington-app
Copy link

miss-islington-appbot commented Nov 24, 2025

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2025
@colesbury@miss-islington
pythongh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (pythongh…
927ebe5
…-141804) (cherry picked from commit c490ffb) Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-appbot commented Nov 24, 2025

GH-141911 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Nov 24, 2025
colesbury added a commit that referenced this pull request Nov 24, 2025
@miss-islington@colesbury
[3.14]gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (gh-141804…
cabaa47
…) (gh-141911) (cherry picked from commit c490ffb) Co-authored-by: Sam Gross <colesbury@gmail.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@colesbury@StanFromIreland
pythongh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (pythongh…
16cc2b2
…-141804)
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
@colesbury@ashm-dev
pythongh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (pythongh…
5a8eb3e
…-141804)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

+1 more reviewer

@ayushHardeniyaayushHardeniyaayushHardeniya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colesbury@encukou@ayushHardeniya