Skip to content

gh-141004: Document stack effect APIs#141843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZeroIntensity merged 3 commits into from
Nov 24, 2025
Merged

gh-141004: Document stack effect APIs #141843

ZeroIntensity merged 3 commits into from
Nov 24, 2025

Conversation

@ZeroIntensity
Copy link
Member

@ZeroIntensityZeroIntensity commented Nov 22, 2025•
edited
Loading

@ZeroIntensityZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 22, 2025
@bedevere-appbedevere-appbot added awaiting core review docs Documentation in the Doc dir skip news labels Nov 22, 2025
@bedevere-appbedevere-appbot mentioned this pull request Nov 22, 2025
Open
StanFromIreland
StanFromIreland reviewed Nov 22, 2025
View reviewed changes
vstinner
vstinner reviewed Nov 24, 2025
View reviewed changes
@ZeroIntensity@vstinner
Update Doc/c-api/veryhigh.rst
ebc1d47
Co-authored-by: Victor Stinner <[email protected]>
vstinner
vstinner approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Doc/c-api/veryhigh.rst
Stack Effects
^^^^^^^^^^^^^
Copy link
Member

@vstinnervstinnerNov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that these funtions belong to "The Very High Level Layer", but I cannot find a better home for them. So I'm fine with documenting them in this file.

Copy link
MemberAuthor

@ZeroIntensityZeroIntensityNov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ideal solution would be to move all the compiler functions to their own file, but unfortunately, we're not allowed to do that without the EB approving it (see #141811 (comment)).

@ZeroIntensityZeroIntensity merged commit e1f1df4 into python:mainNov 24, 2025
32 checks passed
@ZeroIntensityZeroIntensity deleted the document-compile branch November 24, 2025 17:18
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsNov 24, 2025
@miss-islington-app
Copy link

miss-islington-appbot commented Nov 24, 2025

Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2025
@ZeroIntensity@vstinner@miss-islington
pythongh-141004: Document stack effect C APIs (pythonGH-141843)
6c760d0
(cherry picked from commit e1f1df4) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-appbot commented Nov 24, 2025

GH-141916 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2025
@ZeroIntensity@vstinner@miss-islington
pythongh-141004: Document stack effect C APIs (pythonGH-141843)
2afbf33
(cherry picked from commit e1f1df4) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Nov 24, 2025
@bedevere-app
Copy link

bedevere-appbot commented Nov 24, 2025

GH-141917 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Nov 24, 2025
ZeroIntensity added a commit that referenced this pull request Nov 24, 2025
@miss-islington@ZeroIntensity@vstinner
[3.14]gh-141004: Document stack effect C APIs (GH-141843) (GH-141916)
0f2f4c0
gh-141004: Document stack effect C APIs (GH-141843) (cherry picked from commit e1f1df4) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
ZeroIntensity added a commit that referenced this pull request Nov 24, 2025
@miss-islington@ZeroIntensity@vstinner
[3.13]gh-141004: Document stack effect C APIs (GH-141843) (GH-141917)
7905e85
gh-141004: Document stack effect C APIs (GH-141843) (cherry picked from commit e1f1df4) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@ZeroIntensity@vstinner@StanFromIreland
pythongh-141004: Document stack effect C APIs (pythonGH-141843)
b06a385
Co-authored-by: Victor Stinner <[email protected]>
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
@ZeroIntensity@vstinner@ashm-dev
pythongh-141004: Document stack effect C APIs (pythonGH-141843)
a21d953
Co-authored-by: Victor Stinner <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZeroIntensity@vstinner@StanFromIreland