gh-129441: Fix some flakiness in test_instrumentation#141881
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Most of the `self.assertTrue(self.called)` checks are flaky because the worker threads may sometimes finish before the main thread calls `self.during_threads()`.
colesbury added tests 
colesbury added skip news 🔨 test-with-refleak-buildbots 
bedevere-bot commented Nov 23, 2025
🤖 New build scheduled with the buildbot fleet by @colesbury for commit dffc16c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141881%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot removed the 🔨 test-with-refleak-buildbots 
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM. Replacing time.sleep(0.1) with Barrier is a nice fix: sleep() is not a reliable synchronization method. With Barrier, self.called becomes redundant and so can be removed.
vstinner commented Nov 24, 2025
Unrelated failure:
|
colesbury merged commit 71126ab into python:mainUh oh!
There was an error while loading. Please reload this page.
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…-141881) Most of the `self.assertTrue(self.called)` checks are flaky because the worker threads may sometimes finish before the main thread calls `self.during_threads()`. (cherry picked from commit 71126ab) Co-authored-by: Sam Gross <[email protected]>
GH-141913 is a backport of this pull request to the 3.14 branch. |
…-141881) Most of the `self.assertTrue(self.called)` checks are flaky because the worker threads may sometimes finish before the main thread calls `self.during_threads()`. (cherry picked from commit 71126ab) Co-authored-by: Sam Gross <[email protected]>
GH-141914 is a backport of this pull request to the 3.13 branch. |
…) (gh-141913) Most of the `self.assertTrue(self.called)` checks are flaky because the worker threads may sometimes finish before the main thread calls `self.during_threads()`. (cherry picked from commit 71126ab) Co-authored-by: Sam Gross <[email protected]>
…) (gh-141914) Most of the `self.assertTrue(self.called)` checks are flaky because the worker threads may sometimes finish before the main thread calls `self.during_threads()`. (cherry picked from commit 71126ab) Co-authored-by: Sam Gross <[email protected]>
…-141881) Most of the `self.assertTrue(self.called)` checks are flaky because the worker threads may sometimes finish before the main thread calls `self.during_threads()`.
…-141881) Most of the `self.assertTrue(self.called)` checks are flaky because the worker threads may sometimes finish before the main thread calls `self.during_threads()`.
4 participants
Most of the
self.assertTrue(self.called)checks are flaky because the worker threads may sometimes finish before the main thread callsself.during_threads().