gh-116738: Test re module for free threading#141923
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
colesbury left a comment
colesbury left a comment There was a problem hiding this comment.
I'd be inclined to include a NEWS entry. It can be something like:
Make the :func:`re.finditer` reentrancy detection thread-safe. Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
yoney commented Nov 25, 2025
@colesbury Thank you for the review. I have updated the code to use atomics. |
colesbury merged commit bc9e63d into python:main 50 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @yoney for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 26, 2025
…ing (pythongh-141923) Added atomic operations to `scanner_begin()` and `scanner_end()` to prevent race conditions on the `executing` flag in free-threaded builds. Also added tests for concurrent usage of the `re` module. Without the atomic operations, `test_scanner_concurrent_access()` triggers `assert(self->executing)` failures, or a thread sanitizer run emits errors. (cherry picked from commit bc9e63d) Co-authored-by: Alper <alperyoney@fb.com>
GH-141990 is a backport of this pull request to the 3.14 branch. |
colesbury pushed a commit that referenced this pull request Nov 26, 2025
…ding (gh-141923) (gh-141990) Added atomic operations to `scanner_begin()` and `scanner_end()` to prevent race conditions on the `executing` flag in free-threaded builds. Also added tests for concurrent usage of the `re` module. Without the atomic operations, `test_scanner_concurrent_access()` triggers `assert(self->executing)` failures, or a thread sanitizer run emits errors. (cherry picked from commit bc9e63d) Co-authored-by: Alper <alperyoney@fb.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
…ing (pythongh-141923) Added atomic operations to `scanner_begin()` and `scanner_end()` to prevent race conditions on the `executing` flag in free-threaded builds. Also added tests for concurrent usage of the `re` module. Without the atomic operations, `test_scanner_concurrent_access()` triggers `assert(self->executing)` failures, or a thread sanitizer run emits errors.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scanner_begin()andscanner_end()to prevent race conditions on theexecutingflag in free-threaded builds.remodule.Without the atomic operations,
test_scanner_concurrent_access()triggersassert(self->executing)failures, or a thread sanitizer run emits errors.cc: @mpage@colesbury