[3.14] GH-91636: Clear weakrefs created by finalizers. (GH-136401)#141993
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Weakrefs to unreachable garbage that are created during running of finalizers need to be cleared. This avoids exposing objects that have `tp_clear` called on them to Python-level code. (cherry picked from commit b6b99bf) Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
gpshead approved these changes Nov 29, 2025
gpshead merged commit fed2af6 into python:3.14 53 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Member
We decided last week in the Discord to skip this for 3.14.1 and re-consider for 3.14.2, as it's been around for a long time and skipping another point release isn't a big deal. Sorry, I should have commented on this PR before it got merged :) I'll open a revert. |
hugovk added a commit to hugovk/cpython that referenced this pull request Dec 1, 2025
GH-142152 is a backport of this pull request to the 3.14 branch. |
hugovk added a commit that referenced this pull request Dec 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weakrefs to unreachable garbage that are created during running of
finalizers need to be cleared. This avoids exposing objects that
have
tp_clearcalled on them to Python-level code.(cherry picked from commit b6b99bf)
Co-authored-by: Neil Schemenauer nas-github@arctrix.com