Skip to content

Conversation

@encukou
Copy link
Member

@encukouencukou commented Dec 2, 2025

This removes the select added in commit 29c657a.

As Greg put it in https://github.com/python/cpython/pull/119455/files#r2580052775:

why select at all here given we just want to block on reading another chunk?
if the socket closes or errors, that'd return anyways.

This makes the function wait forever for the query body. Thus, the new test 'test_large_content_length_truncated' times out. This was the case before the fix, too.

This removes the select added in commit 29c657a. As Greg put it in https://github.com/python/cpython/pull/119455/files#r2580052775: > why select at all here given we just want to block on reading another chunk? > if the socket closes or errors, that'd return anyways. This makes the function wait forever for the query body. Thus, the new test 'test_large_content_length_truncated' times out. This was the case before the fix, too.
@encukouencukou changed the title gh-119452: Remove select, skip 'truncated' test[3.14] gh-119452: Remove select, skip 'truncated' testDec 2, 2025
@encukou
Copy link
MemberAuthor

#142180 instead uses timeout for each iteration, if the user sets it

@encukouencukou closed this Dec 2, 2025
@encukouencukou reopened this Dec 3, 2025
@serhiy-storchaka
Copy link
Member

Without timeout logic we cannot test that the fix actually works.

@encukouencukou closed this Dec 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@encukou@serhiy-storchaka