Revert "gh-140482: Preserve and restore stty echo as a test environment (#140519)#142196
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…nvironment (python#140519)" Reverts python#140519 This reverts commit b3c713a. Reason: The PR leads to spurious "ENV CHANGED" failures when running tests in an interactive terminal.
ContributorAuthor
colesbury commented Dec 2, 2025
The problem with this approach is that "make test" runs tests in parallel and |
ContributorAuthor
colesbury commented Dec 3, 2025
Closing in favor of: |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #140519.
This reverts commit b3c713a.
Reason: The PR leads to spurious "ENV CHANGED" failures when running tests in an interactive terminal.