gh-142218: Fix split table dictionary crash#142229
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
colesbury added needs backport to 3.13 
Member
pablogsal commented Dec 3, 2025
ContributorAuthor
colesbury commented Dec 3, 2025
Oops, no, it’s the wrong reference |
This fixes a regression introduced in pythongh-140558. The interpreter would crash if we inserted a non `str` key into a split table that matches an existing key.
colesburyforce-pushed the gh-142218-dict-crash branch from b3bf939 to 40e6a1aCompareContributorAuthor
colesbury commented Dec 3, 2025
I've fixed the reference |
methane approved these changes Dec 3, 2025
colesbury merged commit 547d8da into python:main 50 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 3, 2025
This fixes a regression introduced in pythongh-140558. The interpreter would crash if we inserted a non `str` key into a split table that matches an existing key. (cherry picked from commit 547d8da) Co-authored-by: Sam Gross <[email protected]>
Sorry, @colesbury, I could not cleanly backport this to |
GH-142244 is a backport of this pull request to the 3.14 branch. |
colesbury added a commit to colesbury/cpython that referenced this pull request Dec 3, 2025
…2229) This fixes a regression introduced in pythongh-140558. The interpreter would crash if we inserted a non `str` key into a split table that matches an existing key. (cherry picked from commit 547d8da) Co-authored-by: Sam Gross <[email protected]>
GH-142245 is a backport of this pull request to the 3.13 branch. |
colesbury added a commit that referenced this pull request Dec 4, 2025
…2244) This fixes a regression introduced in gh-140558. The interpreter would crash if we inserted a non `str` key into a split table that matches an existing key. (cherry picked from commit 547d8da) Co-authored-by: Sam Gross <[email protected]>
colesbury added a commit that referenced this pull request Dec 4, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
This fixes a regression introduced in pythongh-140558. The interpreter would crash if we inserted a non `str` key into a split table that matches an existing key.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in gh-140558. The interpreter would crash if we inserted a non
strkey into a split table that matches an existing key.