gh-142276: Watch attribute loads when promoting JIT constants#142303
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Misc/NEWS.d/next/Core_and_Builtins/2025-12-05-14-33-54.gh-issue-142276.H4j8hP.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
…e-142276.H4j8hP.rst Co-authored-by: Savannah Ostrowski <[email protected]>
…thon into watch_attribute_loads
MemberAuthor
Fidget-Spinner commented Dec 6, 2025
@YuanchengJiang do I have your permission to use your reproducer for the test case please? |
YuanchengJiang commented Dec 6, 2025
@Fidget-Spinner Thanks for addressing the issue. Feel free to use my reproducers ;) |
markshannon approved these changes Dec 8, 2025
Member
markshannon left a comment
markshannon left a comment There was a problem hiding this comment.
Thanks for fixing this.
Could we simplify test, by changing the attribute between calls to the optimized function, and avoid needing threads? LGTM, either way.
Fidget-Spinner merged commit 97f0a1f into python:main 68 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that we did not watch attribute promotion to constants.
I believe the code was added by @brandtbucher ? So pinging Brandt for a review.
_POP_TOP_INT.c:119: _Py_CODEUNIT *_JIT_ENTRY(_PyInterpreterFrame *, _PyStackRef *, PyThreadState *): Assertion 'PyLong_CheckExact(PyStackRef_AsPyObjectBorrow(value))' failed#142276