gh-142207: remove assertions incompatible under profiling.sampling#142331
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: yihong0618 <[email protected]>
yihong0618 changed the title Signed-off-by: yihong0618 <[email protected]>
Member
StanFromIreland left a comment
StanFromIreland left a comment There was a problem hiding this comment.
Can you please make the title more descriptive, it should give a rough idea of what the PR is about to someone that hasn't read the issue.
yihong0618 changed the title 
ContributorAuthor
yihong0618 commented Dec 6, 2025
changed, sorry for that |
picnixz changed the title profiling.sampling
pablogsal approved these changes Dec 8, 2025
Member
pablogsal commented Dec 8, 2025
Thanks for the fix! |
pablogsal merged commit 3db7bf2 into python:main 50 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as diff
assert!(has_gil && gil_requested)to fail #142207