gh-142363: Improve Tachyon flamegraph contrast#142377
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pablogsal merged commit 3fa1425 into python:main 52 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidebar
Light
Before: The muted grey used for text like "Total Samples" is #8b949e with a contrast ratio of 3.07, below the WCAG AA guideline of 4.5.
After: #6f767e is 4.59, Lighthouse accessibility audit goes from 95% to 100%.
Dark
Before: #6e7681 is 4.11.
After: #757e8a is 4.6.
Tooltip
Make the tooltip location match the (unhighlighted) source code: use
--text-secondary(instead of--text-muted) on--bg-tertiary.Light
2.59 -> 4.56
Dark
3.31 -> 4.94