gh-138122: Tachyon heatmap: Make toggle switches keyboard accessible#142601
+13 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
savannahostrowski approved these changes Dec 11, 2025
Member
savannahostrowski left a comment
savannahostrowski left a comment There was a problem hiding this comment.
Tested it out - this works great! Thanks!
MemberAuthor
Disabled to fix conflicts. And the CI seems to be taking a hit with the outage 😢. |
MemberAuthor
StanFromIreland commented Dec 11, 2025
Ok, conflicts fixed (I don't like doing things with the pressure of auto-merge...). If you could please re-enable it, I'd appreciate it 🖤 |
savannahostrowski merged commit b1c9582 into python:main 44 checks passed
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
StanFromIreland commented Dec 11, 2025
Thanks Pablo and Savannah! |
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screencast.From.2025-12-11.21-18-25.mp4