gh-138122: Fix sample counting for filtered profiling modes#142677
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The live collector's efficiency bar was incorrectly showing 0% success rate when using filtered modes like --mode exception where no thread had an active exception. This happened because samples were only counted as successful when frames were actually processed, conflating "profiler health" with "filter hit rate". Samples are now always counted as successful when the profiler can read from the target process, regardless of whether any frames matched the current filter. This ensures the efficiency bar accurately reflects profiler connectivity rather than filter selectivity. The invariant total_samples == successful_samples + failed_samples is now properly maintained.
pablogsalforce-pushed the tachyon-fix-per branch from e6d07df to b5f672eComparepablogsal merged commit 52daab1 into python:main 85 of 87 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live collector's efficiency bar was incorrectly showing 0% success
rate when using filtered modes like --mode exception where no thread had
an active exception. This happened because samples were only counted as
successful when frames were actually processed, conflating "profiler
health" with "filter hit rate".
Samples are now always counted as successful when the profiler can read
from the target process, regardless of whether any frames matched the
current filter. This ensures the efficiency bar accurately reflects
profiler connectivity rather than filter selectivity. The invariant
total_samples == successful_samples + failed_samples is now properly
maintained.