gh-134584: JIT: Eliminate redundant refcount ops for X_INT#142765
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fidget-Spinner changed the title 35 tasks
Fidget-Spinner changed the title 
savannahostrowski approved these changes Dec 15, 2025
Member
savannahostrowski left a comment
savannahostrowski left a comment There was a problem hiding this comment.
Chatted offline about the tradeoffs of removing REPLACE_OPCODE_IF_EVALUATES_PURE right now (thanks for the clarification @Fidget-Spinner!). For anyone else reading, this is much more valuable since this optimization applies to any LOAD_FAST not just non-immortal constants.
LGTM!
Fidget-Spinner merged commit 790a46a into python:main 70 checks passed
Uh oh!
There was an error while loading. Please reload this page.
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #142764 for why I removed the
REPLACE_OPCODE_IF_EVALUATES_PURE(left, right);for the refcount eliminated ops.News will be covered by the overall What's New entry for the JIT.