gh-142754: Ensure that Element & Attr instances have the ownerDocument attribute#142794
+15 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Element uses __slots__, which means that the attribute is not inherited from the superclass. All other slots (except _localName) are set in __init__; not including ownerDocument was an oversight. Note that creating Element directly is not supported; you're supposed to use Document APIs. All supported ways of creating elements do set ownerDocument. However, many projects ignore the documentation.
encukou changed the title 
Member
hugovk commented Dec 16, 2025
Here's a test case: deftestSetAttributeNodeWithoutOwnerDocument(self): elem=Element("test") attr=Attr("id") attr.value="test-id"elem.setAttributeNode(attr) self.assertEqual(elem.getAttribute("id"), "test-id") |
hugovk approved these changes Dec 16, 2025
encukou added needs backport to 3.13 
hugovk merged commit 1cc7551 into python:main 50 checks passed
Uh oh!
There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
…ocument attribute (pythonGH-142794) (cherry picked from commit 1cc7551) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
…ocument attribute (pythonGH-142794) (cherry picked from commit 1cc7551) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-142818 is a backport of this pull request to the 3.14 branch. |
GH-142819 is a backport of this pull request to the 3.13 branch. |
Member
hugovk commented Dec 16, 2025
Thanks for the fix! |
Contributor
jacobtylerwalls commented Dec 16, 2025
Lovely. Does this also close #67624? |
gpshead pushed a commit to miss-islington/cpython that referenced this pull request Dec 21, 2025
… ownerDocument attribute (pythonGH-142794) (python#142818) pythongh-142754: Ensure that Element & Attr instances have the ownerDocument attribute (pythonGH-142794) (cherry picked from commit 1cc7551) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Dec 22, 2025
…GH-142146) (#142211) * gh-142145: Remove quadratic behavior in node ID cache clearing (GH-142146) * gh-142754: Ensure that Element & Attr instances have the ownerDocument attribute (GH-142794) (cherry picked from commit 1cc7551) (cherry picked from commit 08d8e18) (cherry picked from commit 8d2d7bb) Co-authored-by: Jacob Walls <38668450+jacobtylerwalls@users.noreply.github.com> Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead pushed a commit to miss-islington/cpython that referenced this pull request Dec 22, 2025
… ownerDocument attribute (pythonGH-142794) (python#142818) pythongh-142754: Ensure that Element & Attr instances have the ownerDocument attribute (pythonGH-142794) (cherry picked from commit 1cc7551) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
gpshead pushed a commit to miss-islington/cpython that referenced this pull request Dec 22, 2025
… ownerDocument attribute (pythonGH-142794) (python#142818) pythongh-142754: Ensure that Element & Attr instances have the ownerDocument attribute (pythonGH-142794) (cherry picked from commit 1cc7551) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hroncok pushed a commit to fedora-python/cpython that referenced this pull request Jan 7, 2026
* pythongh-142145: Remove quadratic behavior in node ID cache clearing (pythonGH-142146) * pythongh-142754: Ensure that Element & Attr instances have the ownerDocument attribute (pythonGH-142794) (cherry picked from commit 1cc7551) (cherry picked from commit 08d8e18) (cherry picked from commit 8d2d7bb) Co-authored-by: Jacob Walls <38668450+jacobtylerwalls@users.noreply.github.com> Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
frenzymadness pushed a commit to frenzymadness/cpython that referenced this pull request Jan 8, 2026
* pythongh-142145: Remove quadratic behavior in node ID cache clearing (pythonGH-142146) * pythongh-142754: Ensure that Element & Attr instances have the ownerDocument attribute (pythonGH-142794) (cherry picked from commit 1cc7551) (cherry picked from commit 08d8e18) (cherry picked from commit 8d2d7bb) Co-authored-by: Jacob Walls <38668450+jacobtylerwalls@users.noreply.github.com> Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
frenzymadness pushed a commit to fedora-python/cpython that referenced this pull request Jan 12, 2026
* pythongh-142145: Remove quadratic behavior in node ID cache clearing (pythonGH-142146) * pythongh-142754: Ensure that Element & Attr instances have the ownerDocument attribute (pythonGH-142794) (cherry picked from commit 1cc7551) (cherry picked from commit 08d8e18) (cherry picked from commit 8d2d7bb) Co-authored-by: Jacob Walls <38668450+jacobtylerwalls@users.noreply.github.com> Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
frenzymadness pushed a commit to frenzymadness/cpython that referenced this pull request Jan 14, 2026
* pythongh-142145: Remove quadratic behavior in node ID cache clearing (pythonGH-142146) * pythongh-142754: Ensure that Element & Attr instances have the ownerDocument attribute (pythonGH-142794) (cherry picked from commit 1cc7551) (cherry picked from commit 08d8e18) (cherry picked from commit 8d2d7bb) Co-authored-by: Jacob Walls <38668450+jacobtylerwalls@users.noreply.github.com> Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
pablogsal pushed a commit that referenced this pull request Jan 25, 2026
…GH-142146) (#142213) * gh-142145: Remove quadratic behavior in node ID cache clearing (GH-142146) * Remove quadratic behavior in node ID cache clearing Co-authored-by: Jacob Walls <38668450+jacobtylerwalls@users.noreply.github.com> * Add news fragment --------- (cherry picked from commit 08d8e18) Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Jacob Walls <38668450+jacobtylerwalls@users.noreply.github.com> * [3.14] gh-142754: Ensure that Element & Attr instances have the ownerDocument attribute (GH-142794) (#142818) gh-142754: Ensure that Element & Attr instances have the ownerDocument attribute (GH-142794) (cherry picked from commit 1cc7551) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> * gh-142145: relax the no-longer-quadratic test timing (GH-143030) * gh-142145: relax the no-longer-quadratic test timing * require cpu resource (cherry picked from commit 8d2d7bb) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> * merge NEWS entries into one --------- Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Jacob Walls <38668450+jacobtylerwalls@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
pablogsal pushed a commit that referenced this pull request Jan 25, 2026
…GH-142146) (#142212) * gh-142145: Remove quadratic behavior in node ID cache clearing (GH-142146) * Remove quadratic behavior in node ID cache clearing Co-authored-by: Jacob Walls <38668450+jacobtylerwalls@users.noreply.github.com> * Add news fragment --------- (cherry picked from commit 08d8e18) Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Jacob Walls <38668450+jacobtylerwalls@users.noreply.github.com> * [3.14] gh-142754: Ensure that Element & Attr instances have the ownerDocument attribute (GH-142794) (#142818) gh-142754: Ensure that Element & Attr instances have the ownerDocument attribute (GH-142794) (cherry picked from commit 1cc7551) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> * gh-142145: relax the no-longer-quadratic test timing (GH-143030) * gh-142145: relax the no-longer-quadratic test timing * require cpu resource (cherry picked from commit 8d2d7bb) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> * merge NEWS entries into one --------- Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Jacob Walls <38668450+jacobtylerwalls@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elementuses__slots__, which means that the ownerDocumentattribute is not inherited from the superclass.
All other slots (except
_localName) are set in__init__; notincluding ownerDocument was apparently an oversight.
Note that creating
Elementdirectly is not supported; you're supposedto use Document APIs. AFAICS, all supported ways of creating elements do
set
ownerDocument.However, many projects ignore the documentation, and a security fix that
relies on ownerDocument can break them.