gh-116738: Make lzma module thread-safe#142947
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the attributes in
lzmamodule thread-safe on the free-threading build. Attributes (check,eof,needs_input,unused_data) are now stored atomically or accessed via mutex-protected getters.Even though the operations are protected by locks, the attributes exposed via
PyMemberDef (check, eof, needs_input, unused_data)should still be updated atomically while holding the lock, or accessed via mutex‑protected getters, because they can be read without acquiring the lock.This issue was not addressed in #140711. A small addition that repeatedly reads these attributes shows the issue under tsan build.
cc: @mpage@colesbury