GH-142950: Process format specifiers before colourization in argparse help

[savannahostrowski]

• Issue: Cannot use format specifiers in argparse help #142950

[alexprengere]

Thanks for working on this and fixing the bug I introduced 😭 (I was planning to fix it today but saw your PR).
One minor nit: I tested it locally and this will raise when %% is encountered in the help text:

# parser.add_argument("--str", default="test", help="100%%")#Traceback (mostrecentcalllast): File"/Users/aprengere/Dev/cpython/Lib/argparse.py", line1810, in_check_helpformatter._expand_help(action) ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^File"/Users/aprengere/Dev/cpython/Lib/argparse.py", line712, in_expand_helpraiseValueError(f"invalid format specifier in: {help_string!r}") ValueError: invalidformatspecifierin: '100%%'

This is due to the final check:

if'%'inresult: raiseValueError(f"invalid format specifier in: {help_string!r}")

Removing this check it makes test_invalid_help fail though.

[savannahostrowski]

Hey folks - thanks for the thoughtful and thorough feedback on this PR! Apologies for the delay in addressing it - I was out on vacation over the holidays!