Skip to content

gh-143148: Replace pre-commit with prek in CI#143149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 5 commits into from
Jan 2, 2026
Merged

gh-143148: Replace pre-commit with prek in CI #143149

hugovk merged 5 commits into from
Jan 2, 2026

Conversation

@juhannc
Copy link
Contributor

@juhanncjuhannc commented Dec 24, 2025•
edited by github-actions bot
Loading

@bedevere-app
Copy link

bedevere-appbot commented Dec 24, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot
Copy link

python-cla-botbot commented Dec 24, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-appbedevere-appbot mentioned this pull request Dec 24, 2025
Closed
@bedevere-app
Copy link

bedevere-appbot commented Dec 25, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

juhannc added a commit to juhannc/devguide that referenced this pull request Dec 25, 2025
@juhannc
docs: reflect changes ofpython/cpython#143149
ac93772
@juhanncjuhannc mentioned this pull request Dec 25, 2025
Draft
picnixz
picnixz requested changes Dec 30, 2025
View reviewed changes
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said on the issue, I'm against that change if I need to install prek.

@bedevere-app
Copy link

bedevere-appbot commented Dec 30, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@picnixz
Copy link
Member

picnixz commented Dec 30, 2025•
edited
Loading

In addition, I believe such changes requires a NEWS entry (if we were to do it, and however we do it).

@bedevere-app
Copy link

bedevere-appbot commented Dec 30, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

hugovk
hugovk reviewed Dec 30, 2025
View reviewed changes
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's undo the changes to Makefile in this PR, and just update the CI in this one.

Then we can decide on the Makefile changes in another one.

@AA-Turner@hugovk
Apply suggestions from code review
fef4655
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-appbot commented Dec 31, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

AA-Turner
AA-Turner reviewed Dec 31, 2025
View reviewed changes
@picnixzpicnixz added skip news infra CI, GitHub Actions, buildbots, Dependabot, etc. labels Dec 31, 2025
@AA-Turner
Copy link
Member

AA-Turner commented Dec 31, 2025

I am a little surprised that the action e.g. uses os.execvp (https://github.com/j178/prek-action/blob/main/action.yaml). One option for explitictness (especially in this repo) would be to download & run the prek-installer.sh without the indirection of the action.

A

@hugovk
Copy link
Member

hugovk commented Jan 2, 2026

Let's use the action to simplify maintenance, but please do make suggestions upstream.

@hugovkhugovk merged commit 864c598 into python:mainJan 2, 2026
86 of 89 checks passed
@hugovkhugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 2, 2026
@miss-islington-app
Copy link

miss-islington-appbot commented Jan 2, 2026

Thanks @juhannc for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-appbot commented Jan 2, 2026

Thanks @juhannc for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2026
@juhannc@hugovk
@blurb-it@AA-Turner@miss-islington
pythongh-143148: Replace pre-commit with prek in CI (pythonGH-143149)
3b6f317
(cherry picked from commit 864c598) Co-authored-by: Johann Christensen <johannchristensen@outlook.de> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-appbot commented Jan 2, 2026

GH-143359 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jan 2, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2026
@juhannc@hugovk
@blurb-it@AA-Turner@miss-islington
pythongh-143148: Replace pre-commit with prek in CI (pythonGH-143149)
d134301
(cherry picked from commit 864c598) Co-authored-by: Johann Christensen <johannchristensen@outlook.de> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-appbot commented Jan 2, 2026

GH-143360 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Jan 2, 2026
hugovk added a commit that referenced this pull request Jan 2, 2026
@miss-islington@juhannc
@hugovk@blurb-it@AA-Turner
[3.13]gh-143148: Replace pre-commit with prek in CI (GH-143149) (#14…
08c5bfe
…3359) Co-authored-by: Johann Christensen <johannchristensen@outlook.de> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
hugovk added a commit that referenced this pull request Jan 2, 2026
@miss-islington@juhannc
@hugovk@blurb-it@AA-Turner
[3.14]gh-143148: Replace pre-commit with prek in CI (GH-143149) (#14…
935a366
…3360) Co-authored-by: Johann Christensen <johannchristensen@outlook.de> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This was referenced Jan 2, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ulgensulgens mentioned this pull request Jan 3, 2026
Merged
@hugovkhugovk mentioned this pull request Jan 11, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

@AA-TurnerAA-TurnerAA-Turner left review comments

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@picnixzpicnixzpicnixz approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees

No one assigned

Labels

infraCI, GitHub Actions, buildbots, Dependabot, etc.skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace pre-commit with prek for faster linting

5 participants

@juhannc@picnixz@AA-Turner@hugovk@StanFromIreland