gh-140795: Keep 'err' in local variable in _ssl.c#143275
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The error return code doesn't need to be mutable state on the SSLSocket. This simplifes thread-safety and avoids potential reentrancy issues.
colesbury added skip news type-refactor 
ContributorAuthor
colesbury commented Dec 29, 2025
The motivation here is to refactor out shared state so that we can remove some of the |
picnixz approved these changes Dec 30, 2025
Member
picnixz left a comment
picnixz left a comment There was a problem hiding this comment.
Yeah I don't know why self->err is carried over actually.
gpshead approved these changes Dec 30, 2025
colesbury merged commit 96ab379 into python:main 54 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error return code doesn't need to be mutable state on the SSLSocket. This simplifies thread-safety and avoids potential reentrancy issues.