gh-134584: Eliminate redundant refcounting from _CALL{_BUILTIN_O, _METHOD_DESCRIPTOR_O}#143330
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Fidget-Spinner commented Jan 1, 2026
@corona10 you need to update optimizer_bytecodes.c as well to pass the values. That's why theres no optimization done here! |
Lib/test/test_capi/test_opt.py Outdated
| self.assertIsNotNone(ex) | ||
| uops = get_opnames(ex) | ||
| self.assertIn("_CALL_METHOD_DESCRIPTOR_O", uops) | ||
| self.assertIn("_POP_TOP", uops) |
There was a problem hiding this comment.
@Fidget-Spinner I do believe that we have to implement _CALL_METHOD_DESCRIPTOR_O at optimizer_bytecode.c But it should be for _CALL_BUILTIN_O too.
corona10 commented Jan 1, 2026
Yeah, I left the comment at here #143330 (comment) :) |
corona10 changed the title corona10 changed the title corona10 changed the title corona10 changed the title corona10 changed the title 
Fidget-Spinner added the 🔨 test-with-refleak-buildbots 
bedevere-bot commented Jan 1, 2026
🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 3e6fe60 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143330%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot removed the 🔨 test-with-refleak-buildbots 
Fidget-Spinner left a comment
Fidget-Spinner left a comment There was a problem hiding this comment.
This is fine, I will merge after refleak buildbots pass.
Fidget-Spinner merged commit 1fb8e0e into python:mainUh oh!
There was an error while loading. Please reload this page.
3 participants
Uh oh!
There was an error while loading. Please reload this page.