gh-142927: Hide _sync_coordinator frames from profiler output#143337
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pablogsal added type-bug 
MemberAuthor
pablogsal commented Jan 1, 2026
When running scripts via "python -m profiling.sampling run", the internal _sync_coordinator module appears in stack traces between runpy and user code. These frames are implementation details that clutter the output and provide no useful information to users analyzing their program's behavior. The fix adds a filter_internal_frames function that removes frames from _sync_coordinator.py anywhere in the call stack. This is applied in both the base Collector._iter_all_frames method and directly in GeckoCollector which bypasses the iterator. Tests cover all collector types: pstats, flamegraph, collapsed stack, and gecko formats.
picnixz added awaiting core review and removed type-bug 
pablogsal merged commit 09ce592 into python:main 48 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running scripts via "python -m profiling.sampling run", the internal
_sync_coordinator module appears in stack traces between runpy and user
code. These frames are implementation details that clutter the output and
provide no useful information to users analyzing their program's behavior.
The fix adds a filter_internal_frames function that removes frames from
_sync_coordinator.py anywhere in the call stack. This is applied in both
the base Collector._iter_all_frames method and directly in GeckoCollector
which bypasses the iterator. Tests cover all collector types: pstats,
flamegraph, collapsed stack, and gecko formats.