Skip to content

Conversation

@Aniketsy
Copy link
Contributor

@AniketsyAniketsy commented Jan 3, 2026

This includes changes in 3.12 and 3.13

.. gh-issue: 95185
.. nonce: ghYTZx
.. section: Core and Builtins
.. section: Library

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is wrong, it was fixing the parser?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pointing out.

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ast is a core module,
  • import machinery is a core component

.. gh-issue: 93351
.. nonce: 0Jyvu-
.. section: Core and Builtins
.. section: Library
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ast is a core module. Revert.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

.. gh-issue: 94869
.. nonce: eRwMsX
.. section: Core and Builtins
.. section: Library
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a core and built-in. Other changes to ast are Library because they affect the pure python part of ast.parse.

@Aniketsy
Copy link
ContributorAuthor

@serhiy-storchaka Thanks for the review, I’ve applied the suggested change. I’ll also open a separate issue about removing NEWS entries for Argument Clinic related changes.

@skirpichev
Copy link
Member

In order to keep the commit history intact, please avoid squashing or amending history and then force-pushing to the PR. Reviewers often want to look at individual commits. When the PR is merged, everything will be squashed into a single commit.

Also, do not click the "Update branch" button without a good reason because it notifies everyone watching the PR that there are new changes, when there are not, and it uses up limited CI resources.

@Aniketsy
Copy link
ContributorAuthor

Thanks for pointing this out, I’ll keep it in mind

Also, do not click the "Update branch" button without a good reason because it notifies everyone watching the PR that there are new changes, when there are not, and it uses up limited CI resources.

I wasn’t aware of this before and I apologize for the unnecessary notification.

Co-authored-by: Serhiy Storchaka <[email protected]>
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchakaserhiy-storchaka merged commit 72bacb0 into python:mainJan 19, 2026
32 of 33 checks passed
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsJan 19, 2026
@serhiy-storchakaserhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 19, 2026
@miss-islington-app
Copy link

Thanks @Aniketsy for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @Aniketsy for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2026
@miss-islington-app
Copy link

Sorry, @Aniketsy and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 72bacb0cd0882bce6bd7e9e2e4e9c112d70213e7 3.13 

@bedevere-app
Copy link

GH-144039 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Jan 19, 2026
serhiy-storchaka pushed a commit that referenced this pull request Jan 19, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirneeds backport to 3.13bugs and security fixesskip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants

@Aniketsy@skirpichev@serhiy-storchaka@picnixz@StanFromIreland