Skip to content

gh-143401: Check for unique reference for _BINARY_OP_INPLACE_ADD_UNICODE#143402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Fidget-Spinner wants to merge 3 commits into from
Closed

gh-143401: Check for unique reference for _BINARY_OP_INPLACE_ADD_UNICODE #143402

Fidget-Spinner wants to merge 3 commits into from

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-SpinnerFidget-Spinner commented Jan 4, 2026•
edited
Loading

Fixes#143401

I think this only became a problem after we introduced LOAD_FAST_BORROW. So we should fix it.

@bedevere-appbedevere-appbot mentioned this pull request Jan 4, 2026
Closed
@Fidget-Spinner
Copy link
MemberAuthor

Fidget-Spinner commented Jan 4, 2026

Sorry, this doesn't seem to fix it.

@Fidget-SpinnerFidget-Spinner deleted the fix_binop_refcount branch January 4, 2026 00:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@mpagempageAwaiting requested review from mpage

@colesburycolesburyAwaiting requested review from colesbury

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BINARY_OP_INPLACE_ADD_UNICODE has wrong reference count management

1 participant

@Fidget-Spinner