Skip to content

gh-134584: Eliminate redundant refcounting in TO_BOOL_ALWAYS_TRUE#143427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fidget-Spinner merged 5 commits into from
Jan 6, 2026
Merged

gh-134584: Eliminate redundant refcounting in TO_BOOL_ALWAYS_TRUE #143427

Fidget-Spinner merged 5 commits into from
Jan 6, 2026

Conversation

@reidenong
Copy link
Contributor

@reidenongreidenong commented Jan 5, 2026•
edited by bedevere-app bot
Loading

  • Refactor _REPLACE_WITH_TRUE to leave input on TOS, TO_BOOL_ALWAYS_TRUE to use explicit POP_TOP
  • Refactor optimized _REPLACE_WITH_TRUE op to ensure correct stack effects
  • Add unit tests

@python-cla-bot
Copy link

python-cla-botbot commented Jan 5, 2026•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-appbot commented Jan 5, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-appbedevere-appbot mentioned this pull request Jan 5, 2026
Closed
35 tasks
@bedevere-app
Copy link

bedevere-appbot commented Jan 5, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Fidget-SpinnerFidget-Spinner self-assigned this Jan 5, 2026
Fidget-Spinner
Fidget-Spinner approved these changes Jan 6, 2026
View reviewed changes
Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@Fidget-SpinnerFidget-Spinner merged commit 54f1ed0 into python:mainJan 6, 2026
68 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@tomasr8tomasr8Awaiting requested review from tomasr8tomasr8 is a code owner

Assignees

@Fidget-SpinnerFidget-Spinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reidenong@Fidget-Spinner