Skip to content

gh-141004: Don't trigger run-tests when Tools/check-c-api-docs/ignored_c_api.txt is changed#143583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZeroIntensity merged 4 commits into from
Jan 13, 2026
Merged

gh-141004: Don't trigger run-tests when Tools/check-c-api-docs/ignored_c_api.txt is changed #143583

ZeroIntensity merged 4 commits into from
Jan 13, 2026

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commented Jan 8, 2026•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Jan 8, 2026
Open
@StanFromIrelandStanFromIreland mentioned this pull request Jan 8, 2026
Open
ZeroIntensity
ZeroIntensity reviewed Jan 9, 2026
View reviewed changes
@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Jan 9, 2026

@hugovk maybe you could please take a look?

ZeroIntensity
ZeroIntensity approved these changes Jan 9, 2026
View reviewed changes
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm fine with this. Since it's right before the weekend, I'll give others a few more days to take a look before merging.

Tools/build/compute-changes.py
Comment on lines +26 to +28
Path(".github/CODEOWNERS"),
Path(".pre-commit-config.yaml"),
Path(".ruff.toml"),
Copy link
Member

@ZeroIntensityZeroIntensityJan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth keeping CONFIGURATION_FILE_NAMES and just flattening it here, but I'm not going to block the PR on it.

hugovk
hugovk approved these changes Jan 9, 2026
View reviewed changes
@hugovkhugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 9, 2026
@hugovk
Copy link
Member

hugovk commented Jan 10, 2026

Idle thought, we could write:

ifnot (doc_fileorfileinRUN_TESTS_IGNORE):

As:

ifnotdoc_fileandfilenotinRUN_TESTS_IGNORE:

I think that's a little clearer?

An unrelated condition that could be made clearer in this file is:

ifnothas_platform_specific_changeornotplatforms_changed: aelse: b

Is the same as:

ifnot (has_platform_specific_changeandplatforms_changed): aelse: b

And flip to put the positive first:

ifhas_platform_specific_changeandplatforms_changed: belse: a

StanFromIreland
StanFromIreland commented Jan 10, 2026
View reviewed changes
@ZeroIntensityZeroIntensity merged commit 1176fac into python:mainJan 13, 2026
53 checks passed
@miss-islington-app
Copy link

miss-islington-appbot commented Jan 13, 2026

Thanks @StanFromIreland for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 13, 2026
@StanFromIreland@miss-islington
pythongh-141004: Don't triggerrun-testswhen `Tools/check-c-api-do…
6b00baf
…cs/ignored_c_api.txt` is changed (pythonGH-143583) (cherry picked from commit 1176fac) Co-authored-by: Stan Ulbrych <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 13, 2026
@StanFromIreland@miss-islington
pythongh-141004: Don't triggerrun-testswhen `Tools/check-c-api-do…
bdf3b2a
…cs/ignored_c_api.txt` is changed (pythonGH-143583) (cherry picked from commit 1176fac) Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-appbot commented Jan 13, 2026

GH-143793 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Jan 13, 2026
@bedevere-app
Copy link

bedevere-appbot commented Jan 13, 2026

GH-143794 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jan 13, 2026
@StanFromIrelandStanFromIreland deleted the ignore-capi-tests branch January 13, 2026 13:32
ZeroIntensity pushed a commit that referenced this pull request Jan 13, 2026
@miss-islington@StanFromIreland
[3.13]gh-141004: Don't triggerrun-testswhen `Tools/check-c-api-d…
0770c78
…ocs/ignored_c_api.txt` is changed (GH-143583) (GH-143794) gh-141004: Don't trigger `run-tests` when `Tools/check-c-api-docs/ignored_c_api.txt` is changed (GH-143583) (cherry picked from commit 1176fac) Co-authored-by: Stan Ulbrych <[email protected]>
ZeroIntensity pushed a commit that referenced this pull request Jan 13, 2026
@miss-islington@StanFromIreland
[3.14]gh-141004: Don't triggerrun-testswhen `Tools/check-c-api-d…
a705f57
…ocs/ignored_c_api.txt` is changed (GH-143583) (GH-143793) gh-141004: Don't trigger `run-tests` when `Tools/check-c-api-docs/ignored_c_api.txt` is changed (GH-143583) (cherry picked from commit 1176fac) Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@hugovk@ZeroIntensity