Skip to content

Conversation

@Viicos
Copy link
Contributor

@ViicosViicos commented Jan 12, 2026

I'm wondering if we should also update this section:

This is often the same as ``obj.__annotations__``, but this function makes
the following changes to the annotations dictionary:

This gives some sense that accessing __annotations__ is safe, which is no longer the case.


📚 Documentation preview 📚: https://cpython-previews--143758.org.readthedocs.build/

@ViicosViicos changed the title gh-119180: Document get type hints formatgh-119180: Document the format parameter in typing.get_type_hints()Jan 12, 2026
Do not mention `__annotations__` dictionaries, as this is slightly outdated since 3.14. Rewrite the note about possible exceptions for clarity. Also do not mention imported type aliases, as since 3.12 aliases with the `type` statement do not suffer from this limitation anymore.
@ViicosViicosforce-pushed the document-get-type-hints-format branch from f0779d2 to 9dd2b19CompareJanuary 12, 2026 21:12
@JelleZijlstra
Copy link
Member

This gives some sense that accessing __annotations__ is safe, which is no longer the case.

Yes, would you mind changing that line to reference annotationlib.get_annotations instead?

@AlexWaygoodAlexWaygood removed their request for review January 13, 2026 11:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviewdocsDocumentation in the Doc dirskip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants

@Viicos@JelleZijlstra@StanFromIreland