Skip to content

Conversation

@VanshAgarwal24036
Copy link
Contributor

@VanshAgarwal24036VanshAgarwal24036 commented Jan 13, 2026

This PR updates the tkinter documentation to replace the term “slave” with
neutral alternatives such as “child widget”.

The changes are limited to documentation wording only and do not affect
APIs or behavior.

Fixes#143754.


📚 Documentation preview 📚: https://cpython-previews--143779.org.readthedocs.build/

@VanshAgarwal24036VanshAgarwal24036 changed the title Gh 143754 tkinter neutral termsgh-143754: Use neutral terminology in tkinter documentationJan 13, 2026
@VanshAgarwal24036VanshAgarwal24036force-pushed the gh-143754-tkinter-neutral-terms branch from 102c344 to f50a321CompareJanuary 13, 2026 09:30
@VanshAgarwal24036
Copy link
ContributorAuthor

This PR is documentation-only, so it does not require a NEWS entry.
Could a maintainer please add the skip news label?

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@VanshAgarwal24036
Copy link
ContributorAuthor

Thanks for the clarification.

I’ve updated the paragraph to keep master for the container relationship
while removing slave, and adjusted the wording to stay within the scope
of this PR. I also fixed the winfo_parent markup warning.

Please let me know if this looks good now.

@VanshAgarwal24036
Copy link
ContributorAuthor

VanshAgarwal24036 commented Jan 14, 2026

@terryjreedy I have commited the suggested changes Please review and suggest if any change required

@picnixz
Copy link
Member

I think Serhiy's PR addresses this already and in a better way. What has changed between these two PRs? I would also prefer Serhiy's PR as he has deep tkinter knowledge.

@VanshAgarwal24036
Copy link
ContributorAuthor

Thanks for the clarification. Since Serhiy’s PR already covers this,
I’m happy to defer. Let me know if you’d like me to close this PR or
if you prefer to handle it.

@terryjreedy
Copy link
Member

Thank you for starting this. Serhiy went back to the current tk docs for both docstrings and tkinter.rst.

@VanshAgarwal24036VanshAgarwal24036 deleted the gh-143754-tkinter-neutral-terms branch January 19, 2026 07:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tkinter source and docs use the word 'slave'

4 participants

@VanshAgarwal24036@picnixz@terryjreedy@aisk