Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-143754: Modernize Tkinter docs#143841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-143754: Modernize Tkinter docs #143841
Conversation
serhiy-storchaka commented Jan 14, 2026 • edited by github-actions bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by github-actions bot
Uh oh!
There was an error while loading. Please reload this page.
Use more up to date terminology instead of "master"/"slave" widgets where it is possible.
serhiy-storchaka commented Jan 14, 2026
I used the modern Tk documentation to update the Tkinter documentation. |
| width=amount - width of this widget in pixel | ||
| height=amount - height of this widget in pixel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| width=amount-widthofthiswidgetinpixel | |
| height=amount-heightofthiswidgetinpixel | |
| width=amount-widthofthiswidgetinpixels | |
| height=amount-heightofthiswidgetinpixels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other occurrences of "in pixel" in other places, so I think it is better to fix them in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, the Tk documentation says "in screen units", because not only pixels are supported. You can use millimeters or inches, etc.
terryjreedy left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved except for pluralizing 'pixel'.
813fc7a into python:mainUh oh!
There was an error while loading. Please reload this page.
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Use more relevant terminology instead of "master"/"slave" widgets where possible. (cherry picked from commit 813fc7a291c98654c27f2b5d8f9afa8e53b066a6) Co-authored-by: Serhiy Storchaka <[email protected]>
Use more relevant terminology instead of "master"/"slave" widgets where possible. (cherry picked from commit 813fc7a) Co-authored-by: Serhiy Storchaka <[email protected]>
GH-144032 is a backport of this pull request to the 3.14 branch. |
GH-144033 is a backport of this pull request to the 3.13 branch. |
Use more relevant terminology instead of "master"/"slave" widgets where possible. (cherry picked from commit 813fc7a) Co-authored-by: Serhiy Storchaka <[email protected]>
Use more relevant terminology instead of "master"/"slave" widgets where possible. (cherry picked from commit 813fc7a) Co-authored-by: Serhiy Storchaka <[email protected]>
vstinner commented Jan 19, 2026
Nice change, thanks. |
bedevere-bot commented Jan 19, 2026
|
bedevere-bot commented Jan 19, 2026
|
Use more up to date terminology instead of "master"/"slave" widgets where it is possible.
tkintersource and docs use the word 'slave' #143754📚 Documentation preview 📚: https://cpython-previews--143841.org.readthedocs.build/