Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commented Jan 14, 2026

Use more up to date terminology instead of "master"/"slave" widgets where it is possible.


📚 Documentation preview 📚: https://cpython-previews--143841.org.readthedocs.build/

Use more up to date terminology instead of "master"/"slave" widgets where it is possible.
@serhiy-storchaka
Copy link
MemberAuthor

I used the modern Tk documentation to update the Tkinter documentation.

Comment on lines 2669 to 2670
width=amount - width of this widget in pixel
height=amount - height of this widget in pixel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
width=amount-widthofthiswidgetinpixel
height=amount-heightofthiswidgetinpixel
width=amount-widthofthiswidgetinpixels
height=amount-heightofthiswidgetinpixels

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other occurrences of "in pixel" in other places, so I think it is better to fix them in a separate PR.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, the Tk documentation says "in screen units", because not only pixels are supported. You can use millimeters or inches, etc.

Copy link
Member

@terryjreedyterryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved except for pluralizing 'pixel'.

@serhiy-storchakaserhiy-storchaka merged commit 813fc7a into python:mainJan 19, 2026
58 checks passed
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsJan 19, 2026
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@serhiy-storchakaserhiy-storchaka deleted the tkinter-master-slave-docs branch January 19, 2026 12:01
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2026
Use more relevant terminology instead of "master"/"slave" widgets where possible. (cherry picked from commit 813fc7a291c98654c27f2b5d8f9afa8e53b066a6) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2026
Use more relevant terminology instead of "master"/"slave" widgets where possible. (cherry picked from commit 813fc7a) Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

GH-144032 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Jan 19, 2026
@bedevere-app
Copy link

GH-144033 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jan 19, 2026
serhiy-storchaka added a commit that referenced this pull request Jan 19, 2026
Use more relevant terminology instead of "master"/"slave" widgets where possible. (cherry picked from commit 813fc7a) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jan 19, 2026
Use more relevant terminology instead of "master"/"slave" widgets where possible. (cherry picked from commit 813fc7a) Co-authored-by: Serhiy Storchaka <[email protected]>
@vstinner
Copy link
Member

Nice change, thanks.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.13 (tier-1) has failed when building commit 48a8cd1.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1441/builds/1736) and take a look at the build logs.
  4. Check if the failure is related to this commit (48a8cd1) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1441/builds/1736

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 856, in gc_collect gc.collect() ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True> Traceback (most recent call last): File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 856, in gc_collect gc.collect() ResourceWarning: unclosed file <_io.FileIO name=13 mode='wb' closefd=True>

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.13 (tier-2) has failed when building commit 48a8cd1.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1396/builds/1968) and take a look at the build logs.
  4. Check if the failure is related to this commit (48a8cd1) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1396/builds/1968

Failed tests:

  • test.test_multiprocessing_spawn.test_processes
  • test.test_multiprocessing_forkserver.test_processes

Failed subtests:

  • test_repr_rlock - test.test_multiprocessing_spawn.test_processes.WithProcessesTestLock.test_repr_rlock
  • test_repr_rlock - test.test_multiprocessing_forkserver.test_processes.WithProcessesTestLock.test_repr_rlock

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/Users/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1493, in test_repr_rlockself.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(lock)) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: '<RLock(SomeOtherThread, nonzero)>' != '<RLock(None, 0)>' - <RLock(SomeOtherThread, nonzero)> + <RLock(None, 0)> 

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka@vstinner@bedevere-bot@terryjreedy