Skip to content

gh-143672: Finish conversion of the struct module to Argument Clinic#143857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 3 commits into from
Jan 16, 2026
Merged

gh-143672: Finish conversion of the struct module to Argument Clinic #143857

serhiy-storchaka merged 3 commits into from
Jan 16, 2026
+349 −193

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commented Jan 15, 2026•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Jan 15, 2026
Closed
@serhiy-storchakaserhiy-storchaka changed the title gh-143856: Finish conversion of the struct module to Argument Clinicgh-143672: Finish conversion of the struct module to Argument ClinicJan 15, 2026
@bedevere-appbedevere-appbot mentioned this pull request Jan 15, 2026
Closed
@serhiy-storchakaserhiy-storchaka mentioned this pull request Jan 15, 2026
Closed
skirpichev
skirpichev reviewed Jan 15, 2026
View reviewed changes
skirpichev
skirpichev requested changes Jan 16, 2026
View reviewed changes
@serhiy-storchaka@skirpichev
Re-wrap docstrings and minor clean up.
515ba46
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
serhiy-storchaka
serhiy-storchaka commented Jan 16, 2026
View reviewed changes
Copy link
MemberAuthor

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated docstrings. Please look if I missed something.

skirpichev
skirpichev reviewed Jan 16, 2026
View reviewed changes
Modules/_struct.c
Struct.pack_into
buffer: Py_buffer(accept={rwbuffer})
offset as offset_obj: object
Copy link
Member

@skirpichevskirpichevJan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should deprecate IndexError. OverflowError will be more meaningful here for, well, an overflow condition.

@serhiy-storchakaserhiy-storchaka merged commit 780e969 into python:mainJan 16, 2026
45 checks passed
@serhiy-storchakaserhiy-storchaka deleted the struct-clinic branch January 16, 2026 11:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichevskirpichevskirpichev approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka@skirpichev